Merged
Conversation
#fix FreshRSS#4562 See `<xml:base>` example in https://datatracker.ietf.org/doc/html/rfc4287#section-1.1 First uses item `<xml:base>` if it exists, or the item own link, or the feed's base URL rules (feed URL, or Web site URL)
Alkarex
added a commit
to FreshRSS/simplepie
that referenced
this pull request
Aug 30, 2022
SimplePie was not using the best base link for an item content (instead, it was directly using the feed base). See `<xml:base>` example in https://datatracker.ietf.org/doc/html/rfc4287#section-1.1 First uses item `<xml:base>` if it exists, or the item own link, or the feed's base URL rules (feed URL, or Web site URL) Downstream issue FreshRSS/FreshRSS#4562 Downstream PR FreshRSS/FreshRSS#4565
Member
Author
|
Upstream PR: simplepie/simplepie#744 |
Member
Author
|
Looks fine for me so far. Let's try |
mblaney
pushed a commit
to simplepie/simplepie
that referenced
this pull request
Sep 22, 2022
* Fix item get_base SimplePie was not using the best base link for an item content (instead, it was directly using the feed base). See `<xml:base>` example in https://datatracker.ietf.org/doc/html/rfc4287#section-1.1 First uses item `<xml:base>` if it exists, or the item own link, or the feed's base URL rules (feed URL, or Web site URL) Downstream issue FreshRSS/FreshRSS#4562 Downstream PR FreshRSS/FreshRSS#4565 * tests * Same indenting as other tests Maybe can help with strange CI bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fix #4562
See
<xml:base>example in https://datatracker.ietf.org/doc/html/rfc4287#section-1.1First uses item
<xml:base>if it exists, or the item own link, or the feed's base URL rules (feed URL, or Web site URL)Only maybe for 1.20.0 if sufficient testing is provided, otherwise 1.21.0