Skip to content

SimplePie fix parsing of HTTP Links#4283

Merged
Alkarex merged 2 commits intoFreshRSS:edgefrom
Alkarex:SimplePie-fix-HTTP-links
Mar 22, 2022
Merged

SimplePie fix parsing of HTTP Links#4283
Alkarex merged 2 commits intoFreshRSS:edgefrom
Alkarex:SimplePie-fix-HTTP-links

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Mar 22, 2022

@fix #4279 (part of)

Before, SimplePie was not able to parse an HTTP header such as:

Link: <https://pubsubhubbub.appspot.com>; rel="hub", <https://pubsubhubbub.superfeedr.com>; rel=hub, <https://websubhub.com/hub>; rel="hub"

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2022

@Frenzie It would be great if you could test #4283 + #4282 with your own Web site (or similar dummy instance)

@Frenzie
Copy link
Member

Frenzie commented Mar 22, 2022

I'll give it a go later, but I suspect edge + those two or three commits thrown in, served using the Docker container (make start PORT=…) is likely to be borderline identical to how you tested it?

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2022

To test WebSub, FreshRSS needs to be deployed with a routable address

@Frenzie
Copy link
Member

Frenzie commented Mar 22, 2022

IP with the right port exposed should suffice, right?

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2022

Yes, should be

@math-GH
Copy link
Contributor

math-GH commented Mar 22, 2022

Will it fix #4257 too?

@Frenzie
Copy link
Member

Frenzie commented Mar 22, 2022

Not just fix, that's the issue. 😁 But yes, we need to double check it's parsed properly now.

@Alkarex Alkarex linked an issue Mar 22, 2022 that may be closed by this pull request
@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2022

Will it fix #4257 too?

Ah indeed :-) I did not see that issue (I am a bit in late with my notifications) so thanks for linking

@math-GH
Copy link
Contributor

math-GH commented Mar 22, 2022

I checked. It will fix the issue 4257

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2022

I have tested with several feeds and I could not find any regression. Please confirm when you can, @Frenzie :-)

@Alkarex Alkarex merged commit b0a6335 into FreshRSS:edge Mar 22, 2022
@Alkarex Alkarex deleted the SimplePie-fix-HTTP-links branch March 22, 2022 22:12
@Frenzie
Copy link
Member

Frenzie commented Mar 26, 2022

I don't think I see any issues.

Alkarex added a commit to Alkarex/simplepie that referenced this pull request Apr 25, 2022
Before, SimplePie was not able to parse an HTTP header such as:

```
Link: <https://pubsubhubbub.appspot.com>; rel="hub", <https://pubsubhubbub.superfeedr.com>; rel=hub, <https://websubhub.com/hub>; rel="hub"
```

The new regex complies with https://datatracker.ietf.org/doc/html/rfc8288

See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link

Downstream: FreshRSS/FreshRSS#4283
@Alkarex
Copy link
Member Author

Alkarex commented Apr 25, 2022

Upstream: simplepie/simplepie#729

mblaney pushed a commit to simplepie/simplepie that referenced this pull request May 18, 2022
Before, SimplePie was not able to parse an HTTP header such as:

```
Link: <https://pubsubhubbub.appspot.com>; rel="hub", <https://pubsubhubbub.superfeedr.com>; rel=hub, <https://websubhub.com/hub>; rel="hub"
```

The new regex complies with https://datatracker.ietf.org/doc/html/rfc8288

See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link

Downstream: FreshRSS/FreshRSS#4283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TypeError in lib_phpQuery.php when updating feeds [BUG] Website URL broken after subscribing a feed

3 participants