Skip to content

New core-extensions to allow Docker volumes for third-party extensions#2837

Merged
Alkarex merged 4 commits intoFreshRSS:masterfrom
Alkarex:core-extensions
Mar 22, 2020
Merged

New core-extensions to allow Docker volumes for third-party extensions#2837
Alkarex merged 4 commits intoFreshRSS:masterfrom
Alkarex:core-extensions

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Mar 22, 2020

#Fix #2650
Split our extensions directory into two:

  1. Core extensions shipped with FreshRSS in ./lib/core-extensions/
  2. Third-party extensions modified by end-users in ./extensions/ which can easily be mounted as a Docker volume

Additional testing needed.

#Fix FreshRSS#2650
Split our extensions directory into two:
1) Core extensions shipped with FreshRSS in ./lib/core-extensions/
2) Third-party extensions modified by end-users in ./extensions/ which
can easily be mounted as a Docker volume
@Alkarex Alkarex added this to the 1.16.0 milestone Mar 22, 2020
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2020

Arg, some extensions such as CustomCSS are using EXTENSIONS_PATH in their code
https://github.com/FreshRSS/Extensions/blob/ade2979857e91d838c1835f773797fc70cd7145b/xExtension-CustomCSS/extension.php#L24-L33

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2020

We should start pushing the use of ./data/extensions-data/ as introduced in #1547 to avoid requiring write access in the extensions folder

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2020

I have re-introduced EXTENSIONS_PATH as a legacy constant for back-compatibility, while waiting for updating the extensions to avoid mixing code and data.

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2020

Tested, also with Docker. Existing extensions should not be affected.

@Alkarex
Copy link
Member Author

Alkarex commented Mar 22, 2020

Merging a bit fast, so that I can send another PR depending on it. But feedback still welcome :-)

@Alkarex Alkarex merged commit cd49e98 into FreshRSS:master Mar 22, 2020
@Alkarex Alkarex deleted the core-extensions branch March 22, 2020 15:31
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Mar 22, 2020
#Fix FreshRSS#2835
Add ability to discover RSS feeds for Google Groups
Based on FreshRSS#2837
Alkarex added a commit that referenced this pull request Mar 22, 2020
* Add core extension for Google Groups

#Fix #2835
Add ability to discover RSS feeds for Google Groups
Based on #2837

* Allow HTTP in addition of HTTPS
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request May 30, 2022
Alkarex added a commit that referenced this pull request May 31, 2022
* Docker readme volume for extensions
Forgotten from #4320
Keeping #2837

* Minor whitespace

* No extension volume for development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension not working

2 participants