Merged
Conversation
API: Use SetEnvIf if available and fallback to RewriteRule Docker: Disable unused modules. Docker: Hard-include .htaccess to avoid having to scan for changes in that file. Docker: Disable security check of symlinks, which we do not use ayway.
* Run cron job with correct www-data user instead of root * Remove PHP GMP module uneeded for 64-bit Docker image * Add option to mount custom .htaccess for HTTP authentication * Re-add Apache module for HTTP authentication * Move Alpine-specific instructions to Docker file (instead of Apache conf) to make it easier to have other base images than Alpine
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 1, 2019
* Security fixes when HTTP user does not exist in FreshRSS * Accept HTTP header X-WebAuth-User for delegated HTTP Authentication (e.g. Træfik) * Document delegated HTTP authentication from FreshRSS#2202
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 1, 2019
Ubuntu seems to be faster, cf. e.g. PHPBench on: https://www.phoronix.com/scan.php?page=article&item=freebsd-12-windows&num=5 https://www.phoronix.com/scan.php?page=article&item=docker-summer-2018&num=4 This image is also different from our Alpine-based image as it is using Apache Event and PHP-FPM as FastCGI. They is also supposed to be faster for some types of workload than mod_php but with other drawbacks (poorer control of flush, more processes running...). So some concreate performance tests would be needed to check whether this is relevant at all. It is quite usual for Docker images to offer both a Debian/Ubuntu and an Alpine version, so we could also do the same if there is any need. Follow-up of FreshRSS#2202
Alkarex
added a commit
that referenced
this pull request
Jan 2, 2019
* Security fixes when HTTP user does not exist in FreshRSS * Accept HTTP header X-WebAuth-User for delegated HTTP Authentication (e.g. Træfik) * Document delegated HTTP authentication from #2202
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 6, 2019
* GMP is needed because Alpine on e.g. ARM runs 32-bit FreshRSS#2202 * Remove documentation for Træfik HTTP authentication as it is not compatible with API FreshRSS#2204 FreshRSS#2208 FreshRSS#2207
Alkarex
added a commit
that referenced
this pull request
Jan 6, 2019
Merged
Alkarex
added a commit
that referenced
this pull request
Mar 2, 2019
* Docker image alternative using Ubuntu Ubuntu seems to be faster, cf. e.g. PHPBench. It is quite usual for Docker images to offer both a Debian/Ubuntu and an Alpine version, so we could also do the same if there is any need. Follow-up of #2202 * Only explicit use of Apache confs Fix double-logging issue * Explicit ServerTokens OS Default Apache configuration in Ubuntu, which was removed when disabling all confs. It is also the default Apache configuration in Alpine. * Take advantage of syslog for actualization Same than for Alpine 43ab629 * COPY_SYSLOG_TO_STDERR Same as #2213 * Update to libapache2-mod-php instead of php-fpm * Default to Ubuntu Ubuntu mod-php wins, being ~14% faster than Ubuntu php-fpm (which was ~300% faster than Alpine mod-php)
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Apache performance API: Use SetEnvIf if available and fallback to RewriteRule Docker: Disable unused modules. Docker: Hard-include .htaccess to avoid having to scan for changes in that file. Docker: Disable security check of symlinks, which we do not use ayway. * Apache readme * Docker/Apache tuning Run cron job with correct www-data user instead of root Remove PHP GMP module uneeded for 64-bit Docker image Add option to mount custom .htaccess for HTTP authentication Re-add Apache module for HTTP authentication Move Alpine-specific instructions to Docker file (instead of Apache conf) to make it easier to have other base images than Alpine
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Security fixes when HTTP user does not exist in FreshRSS * Accept HTTP header X-WebAuth-User for delegated HTTP Authentication (e.g. Træfik) * Document delegated HTTP authentication from FreshRSS#2202
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* GMP is needed because Alpine on e.g. ARM runs 32-bit FreshRSS#2202 * Remove documentation for Træfik HTTP authentication as it is not compatible with API FreshRSS#2204 FreshRSS#2208 FreshRSS#2207
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* Docker image alternative using Ubuntu Ubuntu seems to be faster, cf. e.g. PHPBench. It is quite usual for Docker images to offer both a Debian/Ubuntu and an Alpine version, so we could also do the same if there is any need. Follow-up of FreshRSS#2202 * Only explicit use of Apache confs Fix double-logging issue * Explicit ServerTokens OS Default Apache configuration in Ubuntu, which was removed when disabling all confs. It is also the default Apache configuration in Alpine. * Take advantage of syslog for actualization Same than for Alpine FreshRSS@43ab629 * COPY_SYSLOG_TO_STDERR Same as FreshRSS#2213 * Update to libapache2-mod-php instead of php-fpm * Default to Ubuntu Ubuntu mod-php wins, being ~14% faster than Ubuntu php-fpm (which was ~300% faster than Alpine mod-php)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API: Use Apache SetEnvIf if available and fallback to RewriteRule.
Docker: Run cron job with correct www-data user instead of root
Docker: Hard-include Apache .htaccess to avoid having to scan for changes in those files.
Docker: Disable Apache security check of symlinks, which we do not use anyway.
Docker: Disable unused Apache and PHP modules.