[fix] Finishing touches for next/previous without focus#2140
Merged
Alkarex merged 7 commits intoFreshRSS:devfrom Nov 18, 2018
Merged
[fix] Finishing touches for next/previous without focus#2140Alkarex merged 7 commits intoFreshRSS:devfrom
Alkarex merged 7 commits intoFreshRSS:devfrom
Conversation
Alkarex
reviewed
Nov 18, 2018
Alkarex
reviewed
Nov 18, 2018
|
|
||
| if (old_active[0] !== new_active[0]) { | ||
| if (isCollapsed && !skipping) { // BUG?: isCollapsed can only ever be true | ||
| if (isCollapsed && !skipping) { // BUG?: isCollapsed can only ever be true |
Member
There was a problem hiding this comment.
The function declaration a bit higher up contains a default parameter, which is ES6.
function toggleContent(new_active, old_active, skipping = false) { }This might not be compatible with all the browsers we support so far (e.g. IE11?)
I suggest removing the default parameter, and being explicit in all the calls
Alkarex
reviewed
Nov 18, 2018
Member
|
@Frenzie Now that you have become |
Member
Author
|
Sure, but you might have to remind me in a few days. I'm heading off to bed soon. |
Frenzie
added a commit
to Frenzie/FreshRSS
that referenced
this pull request
Nov 28, 2018
…previous_article` todos Cf. FreshRSS#2140 (comment)
Alkarex
pushed a commit
that referenced
this pull request
Nov 28, 2018
…previous_article` todos (#2156) Cf. #2140 (comment)
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
* [fix] Finishing touches for next/previous without focus Cf. FreshRSS#1767. * Avoid single quote Alternative: use `’` * Minor whitespace * Minor whitespace * be explicit about skipping * add todos * overshot by one
mdemoss
pushed a commit
to mdemoss/FreshRSS
that referenced
this pull request
Mar 25, 2021
…previous_article` todos (FreshRSS#2156) Cf. FreshRSS#2140 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf. #1767.