Skip to content

Strip embedded SVG images for now#2135

Merged
Alkarex merged 1 commit intoFreshRSS:devfrom
Alkarex:strip_svg
Nov 18, 2018
Merged

Strip embedded SVG images for now#2135
Alkarex merged 1 commit intoFreshRSS:devfrom
Alkarex:strip_svg

Conversation

@Alkarex
Copy link
Member

@Alkarex Alkarex commented Nov 17, 2018

Fix #2106
Proper SVG support would require custom sanitizing and URL rewriting of
xlink:href, and is left for future work

@Alkarex
Strip embedded SVG images for now
9b10613 
Fix FreshRSS#2106
Proper SVG support would require custom sanitizing and URL rewriting of
xlink:href, and is left for future work
@Alkarex Alkarex added this to the 1.13.0 milestone Nov 17, 2018
@Alkarex Alkarex mentioned this pull request Nov 17, 2018
Closed
Frenzie
Frenzie approved these changes Nov 18, 2018
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pity though.

@Alkarex
Copy link
Member Author

Alkarex commented Nov 18, 2018

@Frenzie Indeed a pity. We could make SVG work again though. But I have not yet seen a legit use of SVG in a RSS feed. Examples welcome.

@Alkarex Alkarex merged commit 9f6919a into FreshRSS:dev Nov 18, 2018
@Alkarex Alkarex deleted the strip_svg branch November 18, 2018 10:35
@Frenzie
Copy link
Member

Frenzie commented Nov 18, 2018

I'm not really sure how else I'd use SVG?

https://fransdejonge.com/category/media/drawing

That being said, normally I don't put the SVG in the HTML like I seem to have done in this one:
https://fransdejonge.com/2015/09/just-a-star/

Also slightly different:
https://openclipart.org/rss/new.xml

Generally speaking the more sensible thing to do is a picture element with an img png/jpg and a source SVG.

But surely I can't uniquely be the only person who's used plain SVG in a "legit" manner?

@Alkarex
Copy link
Member Author

Alkarex commented Nov 18, 2018

Thanks for the example :-)
https://fransdejonge.com/category/media/drawing/feed/
Could you please open another ticket to remember to re-add SVG?

@Frenzie
Copy link
Member

Frenzie commented Nov 18, 2018

Although note that you'll need to use the "Articles CSS path on original website" feature.

@Frenzie Frenzie mentioned this pull request Nov 18, 2018
Open
Alkarex added a commit that referenced this pull request Nov 20, 2018
@Alkarex
Changelog 1767, 2122, 2133, 2134, 2135, 2136, 2137
9d92695 
#1767
#2122
#2133
#2134
#2135
#2136
#2137
@Alkarex Alkarex mentioned this pull request Dec 16, 2018
Merged
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
@Alkarex @mdemoss
Strip embedded SVG images for now (FreshRSS#2135)
6ca087c 
Fix FreshRSS#2106
Proper SVG support would require custom sanitizing and URL rewriting of
xlink:href, and is left for future work
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
@Alkarex @mdemoss
Changelog 1767, 2122, 2133, 2134, 2135, 2136, 2137
4e24432 
FreshRSS#1767
FreshRSS#2122
FreshRSS#2133
FreshRSS#2134
FreshRSS#2135
FreshRSS#2136
FreshRSS#2137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

SimplePie 🍰

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Alkarex @Frenzie