Skip to content

Improve long dropdown menu lists#2108

Merged
Alkarex merged 1 commit intoFreshRSS:devfrom
romibi:fix-long-dropdown-menu
Nov 13, 2018
Merged

Improve long dropdown menu lists#2108
Alkarex merged 1 commit intoFreshRSS:devfrom
romibi:fix-long-dropdown-menu

Conversation

@romibi
Copy link
Contributor

@romibi romibi commented Nov 2, 2018

Issue:

Dropdown menus with lots of entries were a bit difficult to use …
I was only able to see either the bottom of the labels-list or the article and not both …
And I was unable to close the labels menu on my Phone after adding more than 12 labels.

Changes:

I set the max height to 60% 75% of Vieport-height and enabled vertical scrolling … in the theme I use …
for a new dropdown class now used for dropdowns of the "My labels" feature

To Further Improve:

  • Maybe similar changes to other themes are needed.
  • On my (windows) phone i still can't add all labels because i cant scroll the menu … but at least i can close it again without reload …
    Works ok on my Android …

Edit: Changed PR based on responses below

@Frenzie
Copy link
Member

Frenzie commented Nov 2, 2018

And I was unable to close the labels menu on my Phone after adding more than 12 labels.

Could you please explain that a bit more in-depth in order to understand the problem?

Regardless, some kind of media queries should definitely be involved here. Otherwise you get something like this, where it would fit on the screen if it weren't for max-height thing. (That's with what seemed like a more reasonable value, like 75 or 80.)

screenshot_2018-11-02_15-03-43

@romibi
Copy link
Contributor Author

romibi commented Nov 2, 2018

This is the issue:
Image from Gyazo

True … feel free to change 60% to another value … it seemed about right for the labels dropdown … there 60% menu and 40% article seemed right

@Alkarex Alkarex added this to the 1.13.0 milestone Nov 2, 2018
@Alkarex Alkarex added the UI 🎨 User Interfaces label Nov 2, 2018
@Frenzie
Copy link
Member

Frenzie commented Nov 2, 2018

OK, I think I understand the issue now. That means the CSS properties that needs adjusting would be these here:

.dropdown .dropdown-menu {
border-radius: 0;
bottom: 0;
position: fixed;
width: 100%;
}

I'd just get rid of position: fixed, personally.

@romibi
Copy link
Contributor Author

romibi commented Nov 2, 2018

i'd be fine with removing the position: fixed;
but then there is still the issue that if you scroll down the long list of labels you have to scroll up again to get back to the article …

oh and for whatever reason … adding overflow to the css removes the white triangle from the top in the desktop version of the dropdown-menu

and why is there a hidden, unused close button in the dropdown menu?

@Frenzie
Copy link
Member

Frenzie commented Nov 2, 2018

but then there is still the issue that if you scroll down the long list of labels you have to scroll up again to get back to the article …

You could add an overflow-y: scroll of some sort I suppose, but it should surely be inside that media query. :-)

oh and for whatever reason … adding overflow to the css removes the white triangle from the top in the desktop version of the dropdown-menu

To me that's the least of the horrors of applying that style outside of the confines of the problem you were trying to solve. ;-D

and why is there a hidden, unused close button in the dropdown menu?

Interesting, and it's functional too. I was actually going to suggest to try adding something like that, but that makes it a whole lot easier to experiment…

@romibi
Copy link
Contributor Author

romibi commented Nov 2, 2018

but then there is still the issue that if you scroll down the long list of labels you have to scroll up again to get back to the article …

You could add an overflow-y: scroll of some sort I suppose, but it should surely be inside that media query. :-)

no that same issue exists on desktop aka outside that media query …

I was waiting for something like labels for a long time … to categorize my 300+ Favorites i've added 36 labels now … thats a long list … often longer than 2 articles … on some twitter rss feeds even as long as 4 entries

@Frenzie
Copy link
Member

Frenzie commented Nov 2, 2018

no that same issue exists on desktop aka outside that media query …

I suppose we'll have to agree to disagree. I don't see it as an issue on either platform. On the contrary, I think Gmail is somewhat suboptimal (to put it diplomatically) for basically using the proposed method. ;-)

screenshot_2018-11-02_23-08-32

screenshot_2018-11-02_23-16-21

But! The tag thing does open to the bottom, whereas if you open your context menu at the bottom of your screen it goes up instead. A little JS could provide a negative offset?

@romibi
Copy link
Contributor Author

romibi commented Nov 3, 2018

Yes we will probably have to agree to disagree …
But In my opinion it's not userfriendly if you have to scroll up & down to compare the content to potentially fitting labels:

Image from Gyazo

And by scrolling the article while scrolling the labels you easier loose the overview over the article
(well perhaps not in tweets)

Although i personally don't use Gmail and a lot of stuff google does is bad … i don't see whats not ok in your screenshots … i'd even say … yes, a searchbar: let's filter the list below if you start typing a new label … maybe the label you want to create already exists in similar form

@Frenzie
Copy link
Member

Frenzie commented Nov 3, 2018

The principle is fine. Outlook online isn't hugely inferior to Outlook desktop (in this particular way; of course it is). At the same time, I always enjoy how easily I can go through FreshRSS's equivalent list by merely pressing page up and down instead of having to scroll on some particular section of the screen.

This is alright, note how it doesn't randomly cut out a big slice of space like Gmail does:
screenshot_2018-11-03_07-41-08

Okay:
screenshot_2018-11-03_07-43-45

But Outlook's online category management, for instance, utterly unusable if you add more, very disappointing and very Gmail-esque:
screenshot_2018-11-03_07-50-06
screenshot_2018-11-03_07-51-34

i'd even say … yes, a searchbar: let's filter the list below if you start typing a new label … maybe the label you want to create already exists in similar form

Yes, it's a good addition. The problem is that realistically speaking it's the only way of interacting with it. It's just too small otherwise. Like various bizarrely unresizable dialogs in Windows. Most recently I installed new AMD drivers for my GPU and the end user license agreement could be resized neither in window nor font size, nor could it be copied. Making a window resizable is one tiny little flag, but ooooh no, perish the though that someone reads it.

Anyway, back to menus and such, on real desktop applications you get functionality from keys like Home and End. Outlook 365 replicates this. Gmail doesn't.

compare the content to potentially fitting labels:

Interesting use case! I hadn't thought of that.

Setting aside the discussion on menus in general, I really do think that at its best this change wouldn't mess up the other menus too badly while they're better left without. The labels menu seems to be a special case. The application of the scrolling principle can be made generalized, like class="dropdown-menu dropdown-menu-scrollable".

It could also be shorter on thinner windows (so as to cover up less of the content) than on wider ones.

You made a convincing argument that it might be okay for the labels menu not to take up as many pixels as possible, but my biggest objection is to the indiscriminate application of this principle.

screenshot_2018-11-03_08-23-16

Let's say we want all menus to be scrollable. Most menus should take up as much space as they possibly can. 100vh-some padding and stuff. Then there may be menus where that doesn't apply, although like I said before, I think the problem is just that it doesn't open with a negative offset. :-)

@Alkarex
Copy link
Member

Alkarex commented Nov 11, 2018

I have not followed everything. What is the status of this PR, @Frenzie ?

@Frenzie
Copy link
Member

Frenzie commented Nov 11, 2018

Not quite ready yet I'd say. @romibi could you perhaps refactor it slightly with the dropdown-menu-scrollable (or something akin to that) to limit it to the filter menu? :-)

@Alkarex Alkarex added the Work in progress 🚧 Wait before merging label Nov 11, 2018
Dropdown menus with lots of entries were a bit difficult to use …
Set max height to 75% of Viewport-height and enabled scrolling
@romibi romibi force-pushed the fix-long-dropdown-menu branch from 1eb64b1 to d27b647 Compare November 11, 2018 17:52
@romibi
Copy link
Contributor Author

romibi commented Nov 11, 2018

Wasn't sure if you wanted to do it …
… is this ok?

@Frenzie
Copy link
Member

Frenzie commented Nov 11, 2018

Lgtm, thanks!

@Alkarex Alkarex removed the Work in progress 🚧 Wait before merging label Nov 11, 2018
@Alkarex Alkarex merged commit adcbfc4 into FreshRSS:dev Nov 13, 2018
@Alkarex
Copy link
Member

Alkarex commented Nov 13, 2018

Thanks @romibi 👍
Merged in /dev

Alkarex added a commit that referenced this pull request Nov 14, 2018
@romibi romibi deleted the fix-long-dropdown-menu branch December 22, 2019 19:48
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Dropdown menus with lots of entries were a bit difficult to use …
Set max height to 75% of Viewport-height and enabled scrolling
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI 🎨 User Interfaces

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants