Improve long dropdown menu lists#2108
Conversation
Could you please explain that a bit more in-depth in order to understand the problem? Regardless, some kind of media queries should definitely be involved here. Otherwise you get something like this, where it would fit on the screen if it weren't for max-height thing. (That's with what seemed like a more reasonable value, like 75 or 80.) |
|
OK, I think I understand the issue now. That means the CSS properties that needs adjusting would be these here: FreshRSS/p/themes/base-theme/template.css Lines 868 to 873 in e04804d I'd just get rid of |
|
i'd be fine with removing the position: fixed; oh and for whatever reason … adding overflow to the css removes the white triangle from the top in the desktop version of the dropdown-menu and why is there a hidden, unused close button in the dropdown menu? |
You could add an
To me that's the least of the horrors of applying that style outside of the confines of the problem you were trying to solve. ;-D
Interesting, and it's functional too. I was actually going to suggest to try adding something like that, but that makes it a whole lot easier to experiment… |
no that same issue exists on desktop aka outside that media query … I was waiting for something like labels for a long time … to categorize my 300+ Favorites i've added 36 labels now … thats a long list … often longer than 2 articles … on some twitter rss feeds even as long as 4 entries |
I suppose we'll have to agree to disagree. I don't see it as an issue on either platform. On the contrary, I think Gmail is somewhat suboptimal (to put it diplomatically) for basically using the proposed method. ;-) But! The tag thing does open to the bottom, whereas if you open your context menu at the bottom of your screen it goes up instead. A little JS could provide a negative offset? |
|
Yes we will probably have to agree to disagree … And by scrolling the article while scrolling the labels you easier loose the overview over the article Although i personally don't use Gmail and a lot of stuff google does is bad … i don't see whats not ok in your screenshots … i'd even say … yes, a searchbar: let's filter the list below if you start typing a new label … maybe the label you want to create already exists in similar form |
|
I have not followed everything. What is the status of this PR, @Frenzie ? |
|
Not quite ready yet I'd say. @romibi could you perhaps refactor it slightly with the |
Dropdown menus with lots of entries were a bit difficult to use … Set max height to 75% of Viewport-height and enabled scrolling
1eb64b1 to
d27b647
Compare
|
Wasn't sure if you wanted to do it … |
|
Lgtm, thanks! |
|
Thanks @romibi 👍 |
Dropdown menus with lots of entries were a bit difficult to use … Set max height to 75% of Viewport-height and enabled scrolling










Issue:
Dropdown menus with lots of entries were a bit difficult to use …
I was only able to see either the bottom of the labels-list or the article and not both …
And I was unable to close the labels menu on my Phone after adding more than 12 labels.
Changes:
I set the max height to
60%75% of Vieport-height and enabled vertical scrolling …in the theme I use …for a new dropdown class now used for dropdowns of the "My labels" feature
To Further Improve:
Maybe similar changes to other themes are needed.Works ok on my Android …
Edit: Changed PR based on responses below