Automatic feed channel icons feature for xExtension-YouTube#337
Merged
Alkarex merged 23 commits intoFreshRSS:masterfrom Aug 18, 2025
Merged
Automatic feed channel icons feature for xExtension-YouTube#337Alkarex merged 23 commits intoFreshRSS:masterfrom
Alkarex merged 23 commits intoFreshRSS:masterfrom
Conversation
Alkarex
reviewed
Jun 17, 2025
Alkarex
reviewed
Jun 17, 2025
Alkarex
reviewed
Jun 17, 2025
Alkarex
reviewed
Jun 17, 2025
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Alkarex
reviewed
Jun 30, 2025
Alkarex
pushed a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Jun 30, 2025
Closes #3789, #6503 Icon setting when no custom icon is set yet:  - `Change...` button opens a file dialog, and after selecting a file shows the chosen icon in the preview on the left. `Submit` must be clicked after selecting the icon. - `Reset to default` changes the preview icon to the default one, and also requires `Submit` to be clicked to apply the changes. Full list of changes: - CSP now includes `blob:` in `img-src` for - `indexAction()` and `feedAction()` in `subscriptionController.php` - all of the view actions in `indexController.php` - Introduce new attribute `customFavicon (boolean)` for feeds that indicates if the feed has a custom favicon - `hashFavicon()` in `Feed.php` is dependent on this attribute - `hashFavicon()` has a new parameter called `skipCache (boolean)` that allows the reset of the favicon hash for the Feed object - `resetFaviconHash()` just calls `hashFavicon(skipCache: true)` - `f.php` URLs now have the format of `/f.php?h=XXXXX&t=cachebuster`, where the `t` parameter is only used for serving custom favicons - if `t` parameter is set, `f.php` returns a `Cache-Control: immutable` header - `stripos` and `strpos` were changed to `str_contains` in various places (refactor) - JS for handling the custom favicon configuration logic is in `extra.js` inside `init_update_feed()` which is called when feed configuration is opened from the aside or when the subscription management page with the feed is loaded - Server-side code for uploading the icon in `subscriptionController.php` under `feedAction()` - Errors that may occur during the setting of a custom favicon: - Unsupported image file type (handled only server-side with `isImgMime()`) - When the file is bigger than 1 MiB (default), handled both client-side and server-side - Standard feed error when `updateFeed()` fails - JS vars `javascript_vars.phtml` are no longer escaped with `htmlspecialchars()`, instead with json encoding, - CSS for disabled buttons was added - Max favicon file size is configurable with the `max_favicon_upload_size` option in `config.php` (not exposed via UI) - Custom favicons are currently deleted only when they are either reset to the default icon, or the feed gets deleted. They do not get deleted when the user deletes their account without removing their feeds first. - ` faviconPrepare()` and `faviconRebuild()` are not allowed to be called when the `customFavicon` attribute is `true` - New i18n strings: - `'sub.feed.icon' => 'Icon'` - `'sub.feed.change_favicon' => 'Change…'` - `'sub.feed.reset_favicon' => 'Reset to default'` - `'sub.feed.favicon_changed_by_ext' => 'The icon has been set by the <b>%s</b> extension.'` - `'feedback.sub.feed.favicon.too_large' => 'Uploaded icon is too large. The maximum file size is <em>%s</em>.'` - `'feedback.sub.feed.favicon.unsupported_format' => 'Unsupported image file format!'` - Extension hook `custom_favicon_hash` - `setCustomFavicon()` method - `resetCustomFavicon()` method - `customFaviconExt` and `customFaviconDisallowDel` attributes - example of usage: FreshRSS/Extensions#337 - Extension hook `custom_favicon_btn_url` - Allows extensions to implement a button for setting a custom favicon for individual feeds by providing an URL. The URL will be sent a POST request with the `extAction` field set to either `query_icon_info` or `update_icon`, along with an `id` field which describes the feed's ID.
Alkarex
reviewed
Aug 5, 2025
| headers: { | ||
| 'Content-Type': 'application/json; charset=UTF-8' | ||
| } | ||
| }).then(resp => { |
Member
There was a problem hiding this comment.
Not urgent, but I think it would be nicer to update to async / await at some point
Member
Author
There was a problem hiding this comment.
Maybe, I think it's good enough for now
Member
|
@kevinpapst if you are around, any feedback here? |
Member
|
Ping @ImAReplicant, @pax0707 |
Member
Thanks for the quick feedback :-) |
Member
|
Let's merge after the release of FreshRSS 1.27.0 |
Member
Author
|
@Alkarex can be merged now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Dependent on FreshRSS/FreshRSS#7646
Right now, the icon only gets set after the feed is added.
(the correct setting must be enabled in order for the icons to be downloaded)
TODO: