Remove using_mbedtls folder and move its content to the parent folder #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yourslab
reviewed
Nov 17, 2021
| <ClCompile Include="..\..\..\Source\Application-Protocols\network_transport\sockets_wrapper\freertos_plus_tcp\sockets_wrapper.c"> | ||
| <Filter>FreeRTOS+\FreeRTOS IoT Libraries\platform\transport</Filter> | ||
| </ClCompile> | ||
| <ClCompile Include="..\..\..\Source\Application-Protocols\network_transport\using_mbedtls\using_mbedtls\using_mbedtls.c"> |
Contributor
There was a problem hiding this comment.
I notice we have two subdirectories under using_mbedtls:
using_mbedtls
..using_mbedtls
..using_mbedtls_pkcs11
It is not obvious what using_mbedtls. We can rename it to something like using_mbedlts_no_pkcs11. However, it might be better to just remove it out of subdirectory and put both folders in upper level directory. I am fine with either option.
Contributor
Author
There was a problem hiding this comment.
I'd like to make it in upper layer, will make the changes.
778f8c3 to
b20f8b0
Compare
yourslab
approved these changes
Nov 18, 2021
aggarg
approved these changes
Nov 18, 2021
johnrhen
pushed a commit
to johnrhen/FreeRTOS
that referenced
this pull request
Nov 24, 2021
…FreeRTOS#717) Move the contents of FreeRTOS/FreeRTOS-Plus/Source/Application-Protocols/network_transport/using_mbedtls/ to its parent folder i.e. FreeRTOS/FreeRTOS-Plus/Source/Application-Protocols/network_transport/. This removes one unnecessary folder in the hierarchy.
moninom1
pushed a commit
to moninom1/FreeRTOS
that referenced
this pull request
Apr 17, 2023
* Use CBMC XML output to enable VSCode debugger (FreeRTOS#673) Prior to this commit, CBMC would emit logging information in plain text format, which does not contain information required for the CBMC VSCode debugger. This commit makes CBMC use XML instead of plain text. Co-authored-by: Mark Tuttle <tuttle@acm.org> * wip * wip DHCPProcess * wip dhcp process * wip * fix CBMC ProcessDHCPReplies proofs * wip DHCPProcess * fix DHCPProcess CBMC proof * fix DHCPProcess CBMC proof * added multiple end point * fix ProcessDHCPReplies * fix function sign. * fix DHCP CBMC proofs * NULL assume to assignment * updating with changes wrt review comments * adding more non determinism to the proof * free memory in FreeRTOS_ReleaseUDPPayloadBuffer * WIP DHCPProcess CBMC proof * wip DHCP process * reverting back to old version * adding more comments --------- Co-authored-by: Kareem Khazem <karkhaz@amazon.com> Co-authored-by: Mark Tuttle <tuttle@acm.org>
urutva
pushed a commit
to urutva/FreeRTOS
that referenced
this pull request
Aug 29, 2023
* Initial Version Pull Request Workflow * Updated Contributing.md * Improved contributing.md * added pr process image and some edits based on peer feedback * fixed links to image * Fixed truncation * Updated reviewer description * Review feedback --------- Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com>
Zangetsu112
pushed a commit
to Zangetsu112/FreeRTOS-evpp
that referenced
this pull request
Aug 18, 2025
…FreeRTOS#717) Move the contents of FreeRTOS/FreeRTOS-Plus/Source/Application-Protocols/network_transport/using_mbedtls/ to its parent folder i.e. FreeRTOS/FreeRTOS-Plus/Source/Application-Protocols/network_transport/. This removes one unnecessary folder in the hierarchy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the contents of
FreeRTOS/FreeRTOS-Plus/Source/Application-Protocols/network_transport/using_mbedtls/to its parent folder i.e.FreeRTOS/FreeRTOS-Plus/Source/Application-Protocols/network_transport/. This removes one unnecessary folder in the hierarchy.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.