Initial transport layer implementation#1
Merged
awakecoding merged 9 commits intoFreeRDP:masterfrom Jul 3, 2011
llyzs:network
Merged
Initial transport layer implementation#1awakecoding merged 9 commits intoFreeRDP:masterfrom llyzs:network
awakecoding merged 9 commits intoFreeRDP:masterfrom
llyzs:network
Conversation
added 9 commits
July 3, 2011 09:50
awakecoding
added a commit
that referenced
this pull request
Jul 3, 2011
Initial transport layer implementation
Closed
Closed
akallabeth
pushed a commit
that referenced
this pull request
Apr 8, 2024
found by coverity
705 if (transferDir == USBD_TRANSFER_DIRECTION_OUT)
706 {
18. Condition !Stream_CheckAndLogRequiredLengthEx("com.freerdp.channels.urbdrc.client" /* "com.freerdp.channels.urbdrc.client" */, 3, s, OutputBufferSize, 1, "%s(%s:%zu)" /* "%s(%s:%zu)" */, <anonymous>, "/home/runner/work/FreeRDP/FreeRDP/channels/urbdrc/client/data_transfer.c", 707UL /* (size_t)707 */), taking true branch.
707 if (!Stream_CheckAndLogRequiredLength(TAG, s, OutputBufferSize))
CID 424733: (#1 of 1): Resource leak (RESOURCE_LEAK)
19. leaked_storage: Variable out going out of scope leaks the storage it points to.
708 return ERROR_INVALID_DATA;
709 Stream_Copy(s, out, OutputBufferSize);
710 }
akallabeth
pushed a commit
that referenced
this pull request
Apr 8, 2024
found by coverity 655 if (Stream_Write_UTF16_String_From_UTF8(s, tmpDirCharLen - 1, tempDirectory->szTempDir, 656 ARRAYSIZE(tempDirectory->szTempDir), TRUE) < 0) CID 424748: (#1 of 1): Resource leak (RESOURCE_LEAK) 9. leaked_storage: Variable s going out of scope leaks the storage it points to. 657 return ERROR_INTERNAL_ERROR; 658 /* Path must be 260 UTF16 characters with '\0' termination. 659 * ensure this here */
akallabeth
pushed a commit
that referenced
this pull request
Apr 8, 2024
found by coverity 128 if (winpr_asprintf(&headers, &size, post_header_fmt, path, hostname, blen) < 0) CID 424888: (#1 of 1): Resource leak (RESOURCE_LEAK) 15. leaked_storage: Variable hostname going out of scope leaks the storage it points to. 129 return FALSE; 130 }
qmfrederik
pushed a commit
to qmfrederik/FreeRDP
that referenced
this pull request
Nov 10, 2024
Fix hanging RDP connection when opposite side is down and thru forwarder
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With unit testing, it's already ok to send the first X.224 Connection Request PDU, and received X.224 Connection Confirm PDU from server.