PERF: RemoveAll Tests and ensure we return a deterministic remove all count + batching#99
Merged
niemyjski merged 1 commit intobugfix/cache-client-list-item-sliding-cache-expirationfrom Apr 24, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces performance improvements by ensuring that the RemoveAll functionality returns a deterministic count and uses batching for key deletion. Key changes include:
- Adding new tests for RemoveAll and RemoveAllKeys in both RedisHybridCacheClientTests and RedisCacheClientTests.
- Implementing batching logic for key deletion in RedisCacheClient.cs with a configurable batch size.
- Adding extension methods for batching in IEnumerable and IAsyncEnumerable to support the changes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Foundatio.Redis.Tests/Caching/RedisHybridCacheClientTests.cs | Added tests for RemoveAll and RemoveAllKeys functionality |
| tests/Foundatio.Redis.Tests/Caching/RedisCacheClientTests.cs | Added tests for RemoveAll and RemoveAllKeys functionality |
| src/Foundatio.Redis/Extensions/EnumerableExtensions.cs | New batching extension methods for IEnumerable and IAsyncEnumerable |
| src/Foundatio.Redis/Cache/RedisCacheClient.cs | Updated RemoveAllAsync to use batching and return a deterministic delete count |
Comments suppressed due to low confidence (1)
src/Foundatio.Redis/Cache/RedisCacheClient.cs:117
- [nitpick] Consider renaming the iteration variable 'redisKeys' to 'keyBatch' (or a similar name) to clearly indicate that it represents a batch of keys.
foreach (var redisKeys in keys.Where(k => !String.IsNullOrEmpty(k)).Select(k => (RedisKey)k).Batch(batchSize))
niemyjski
commented
Apr 23, 2025
niemyjski
commented
Apr 23, 2025
Comment on lines
+102
to
+107
| var seen = new HashSet<RedisKey>(); | ||
| await foreach (var key in server.KeysAsync().ConfigureAwait(false)) | ||
| await Database.KeyDeleteAsync(key).AnyContext(); | ||
| seen.Add(key); | ||
|
|
||
| foreach (var batch in seen.Batch(batchSize)) | ||
| deleted += await Database.KeyDeleteAsync(batch.ToArray()).AnyContext(); |
Member
Author
There was a problem hiding this comment.
We could do this to basically get very low memory footprint but then the key count isn't deterministic as scan can return duplicates.
await foreach (var redisKeys in server.KeysAsync().BatchAsync(batchSize).ConfigureAwait(false))
deleted += await Database.KeyDeleteAsync(redisKeys).AnyContext();
niemyjski
commented
Apr 23, 2025
|
|
||
| int count = 0; | ||
| foreach (var key in redisKeys) | ||
| foreach (var redisKeys in keys.Where(k => !String.IsNullOrEmpty(k)).Select(k => (RedisKey)k).Batch(batchSize)) |
Member
Author
There was a problem hiding this comment.
Batch size matches the size that SE client uses internally for getting batches of keys. So I just reused it, higher count like 1k went faster but then it's basically getting batches and sending batches with better alignment.
ejsmith
approved these changes
Apr 24, 2025
4167562
into
bugfix/cache-client-list-item-sliding-cache-expiration
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
FoundatioFx/Foundatio#377
#97