Conversation
…d each cache item expires independently
PERF: RemoveAll Tests and ensure we return a deterministic remove all count + batching
ejsmith
approved these changes
Apr 24, 2025
… on hashslot but I think at the cost of memory.
Member
Author
|
@Seadoo2017 Can you please review this pr. I had to add a retry to the test we added in #64 and I'm just curious what all changed or if it's still needed. Passes most of the time and I don't see anything that would have changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on FoundatioFx/Foundatio#376..
We should look for any race conditions and possibly even more so around how we set the list root key expiration after add or remove (existing behavior).