Fix regression in SuperEditor pattern tags test#3013
Merged
Conversation
matthew-carroll
approved these changes
May 8, 2026
09f3389
into
Flutter-Bounty-Hunters:main
19 of 23 checks passed
matthew-carroll
pushed a commit
that referenced
this pull request
May 8, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New implementation of
getAttributionSpansInRangediverged from original in case when there are multiple start markers for single attribution without an end marker in-between. I didn't think that was an expected situation but apparently it happens at least temporarily.This PR fixes the issue by not overwriting the first start marker.