[AttributedText] Improve performance of getAttributionSpansInRange#3010
Merged
matthew-carroll merged 6 commits intoMay 7, 2026
Merged
Conversation
Contributor
Author
|
The updated test originally seemed to rely on ordering within the set which doesn't seem like behavior that we should depend on. |
This comment was marked as outdated.
This comment was marked as outdated.
ba8ff0d to
840b139
Compare
Refactor attribution span matching logic for clarity.
matthew-carroll
approved these changes
May 7, 2026
1f3ee3a
into
Flutter-Bounty-Hunters:main
22 of 23 checks passed
matthew-carroll
pushed a commit
that referenced
this pull request
May 8, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AttributedSpans.getAttributionSpansInRangefrequently appears in a hot codepath and current implementation seems to have cubic complexity. This PR replaces it with simpler implementation that only traverses the attributes once.