[Super Editor][IME][Bug] - Fix: Tag deletion error when using Microsoft SwiftKey keyboard (Resolves #2975)#2976
Merged
matthew-carroll merged 1 commit intoMar 10, 2026
Conversation
…ft SwiftKey keyboard (Resolves #2975)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Super Editor][IME][Bug] - Fix: Tag deletion error when using Microsoft SwiftKey keyboard (Resolves #2975)
The behavior coming from the keyboard that caused us a problem was that when deleting a character in a tag, the SwiftKey keyboard would report the deletion along with a composing region that included the upstream word. The tag reaction would then delete the whole tag, making the composing region invalid. We would then send an update back to the IME with the entire tag deleted, and a composing region that exceeded the length of the text, which resulted in an IME error.
The root cause was two related things:
This nuanced composing region management seems like a mess. It would be nice if there were a more holistic way to deal with it, but I'm not sure what it is. There are cases where we definitely want to keep the composing region, e.g., when composing a compound character. So we can't just throw it out all the time.