[Super Editor][IME][Bug] - Samsung: Error when backspacing stable tag at start of text, cause is not clearing composing region (Resolves #2970)#2971
Merged
matthew-carroll merged 1 commit intoMar 9, 2026
Conversation
… at start of text, cause is not clearing composing region (Resolves #2970)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Super Editor][IME][Bug] - Samsung: Error when backspacing stable tag at start of text, cause is not clearing composing region (Resolves #2970)
We weren't clearing the composing region in various content and selection altering commands. This can lead to invalid document ranges that we try to send to the IME.
The IME on iOS and Google devices seemed to handle this gracefully, but Samsung reports an error.
Now we clear the composing region in the various deletion operations I found.
There may be other operations that should clear the IME, too. This change may not be exhaustive.