Conversation
for MMA mode, addresses #172
This was referenced Feb 8, 2025
derselbst
added a commit
that referenced
this pull request
Feb 15, 2025
* Update the documentation about the `load` shell comand * Revise error handling of the `load` shell command * Allow drum channels to profit from Bank Offsets by no longer ignoring MSB Bank changes for drum channels (second try after #176) * Make the preset fallback logic on drum channels more predictable, to migitage my concerns in 883b640. I.e. instead of directly falling back to preset `128:0`, we are now falling back to bank 128, while keeping the currently set program. And only if that fails as well, we pick the standard drum kit at `128:0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for MMA mode, addresses #172