Conversation
Contributor
|
It fixes the problem, but now I get: when running fluidsynth. |
Member
Author
|
No, sry. Return semantics have changed with SDL3 - I forgot. And I currently have no (lightweight) way to test this. Pls. let me know if it works now. |
|
spessasus
approved these changes
Mar 24, 2025
Contributor
spessasus
left a comment
There was a problem hiding this comment.
Sorry for the late reply, but it works like a charm now! LGTM!
Member
Author
|
Great, thanks for confirming! |
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Apr 7, 2025
* master: (51 commits) Put fluidsynth.lock in its own directory (FluidSynth#1528) Fix XG Drum bank selection (FluidSynth#1514) Stop SDL3 intercepting signals (FluidSynth#1520) Fix MSVC type truncation warnings (FluidSynth#1515) Fix SDL3.dll not included in prebuilt Windows Binaries (FluidSynth#1518) Fix Altitude test case Update testcases for FluidSynth#1508 Apply *_FOR_BUILD environment variables to gentables (FluidSynth#1501) Add testfiles for FluidSynth#1496 and FluidSynth#1505 Remove unused enum Bump to 2.4.4 Fix ordering and dependencies in fluidsynth.service file (FluidSynth#1500) fluidsynth.1: Some remarks and a patch with editorial changes for this man page (FluidSynth#1499) Add support for SDL3 (FluidSynth#1485) Fix interruptions of real-time playback (FluidSynth#1494) Add two more test cases Log SysEX System ON Messages Return error code on server failure Rephrase error messages for clarity Only run one FluidSynth service at a time ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1509