Fix errors when switching user#1491
Merged
derselbst merged 3 commits intoFluidSynth:masterfrom Mar 1, 2025
Merged
Conversation
Trying to run a second server will fail unless the user has configured a non-default port. This happens every time a user switches user, because the display manager is implemented as a systemd user session. Use a lock file to avoid that happening. This gets rid of an error message for most users, but forces advanced users to override the systemd configuration. Such users should be smart enough to see the condition failure in the logs, check fluidsynth.service, and understand the hint about `systemctl edit`.
I got the following error while investigating an issue where FluidSynth
failed binding to port 9800:
fluidsynth: error: Failed to bind server socket: 98
It took a long while to realise "98" was an error code, not a sign that
"9800" had been truncated somehow.
Rephrase the errors to avoid confusion.
This is particularly useful when started by systemd. Without this change, the service exits normally without telling systemd it started, leading to an unhelpful "protocol" message from systemd.
|
github-actions bot
pushed a commit
to tedd-an/bluez-upstream-test
that referenced
this pull request
Apr 18, 2025
Obex is a device-oriented protocol, so only one instance can run per device. But Linux file security is user-oriented, so obexd should be a user service. Tell systemd to only run this service for the first non-system user to log in. Without this patch, errors like the following will occur if you use the "switch account" feature of your desktop environment, then log in with another account: Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 00001133-0000-1000-8000-00805f9b34fb which is already registered Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 00001132-0000-1000-8000-00805f9b34fb which is already registered Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 0000112f-0000-1000-8000-00805f9b34fb which is already registered Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 00001104-0000-1000-8000-00805f9b34fb which is already registered Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 00001106-0000-1000-8000-00805f9b34fb which is already registered Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 00001105-0000-1000-8000-00805f9b34fb which is already registered Mar 26 15:20:38 andrews-2024-laptop bluetoothd[873]: src/profile.c:register_profile() :1.2016 tried to register 00005005-0000-1000-8000-0002ee000001 which is already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered Mar 26 15:20:38 andrews-2024-laptop obexd[1795560]: bluetooth: RequestProfile error: org.bluez.Error.NotPermitted, UUID already registered The above errors indicate the service completely failed to register, so this does not change the user experience beyond removing the above messages. Specifically, the first user who logs in to a multi-user system still retains obex access to devices paired by users who log in later. This is based on a pair of recent changes to the FluidSynth daemon: FluidSynth/fluidsynth#1491 FluidSynth/fluidsynth#1528 This was discussed in the comments for a GitHub advisory available at GHSA-fpgq-25xf-jcwv but comments are not shown in the published version of the advisory. To summarise the useful conversation with Luiz Augusto von Dentz: Obex requires access to the user's home directory, so an attacker can only transfer files between locations the user controls. That may be a problem if the user who runs obexd is different to the user who paired the device, but solving that would involve pairing per-user, which causes other problems. Bluetooth connections can be initiated by peripherals, so switching user could trigger re-pairing and cause the original user to lose access to the device. This may seem reasonable for file access, but for example users would likely object to constantly re-pairing their Bluetooth keyboard.
dangowrt
added a commit
to dangowrt/packages
that referenced
this pull request
Apr 26, 2025
fluidsynth 2.4.5
Prebuilt Windows Binaries were missing SDL3.dll
(FluidSynth/fluidsynth#1510)
Fix SDL3 intercepting signals, causing CTRL+C to not quit fluidsynth
(FluidSynth/fluidsynth#1509)
Fix a few flaws in the AWE32 NRPN implementation
(FluidSynth/fluidsynth#1452, FluidSynth/fluidsynth#1473)
A regression introduced in 2.4.4 broke drum preset selection for XG
MIDIs (FluidSynth/fluidsynth#1508)
Fix for OpenMP thread affinity crashes on Android devices
(FluidSynth/fluidsynth#1521, thanks to @looechao)
Fix fluidsynth's systemd user daemon being unable to create lock
file on some distros (FluidSynth/fluidsynth#1527, thanks to
@andrew-sayers)
Fix fluidsynth ignoring initialFilterFc generator limits
(FluidSynth/fluidsynth#1502)
A regression introduced in 2.3.6 prevented SF2 NRPN messages from
being processed correctly (FluidSynth/fluidsynth#1536)
fluidsynth 2.4.4
Support for SDL3 has been added, support for SDL2 has been
deprecated (FluidSynth/fluidsynth#1485, FluidSynth/fluidsynth#openwrt#1478,
thanks to @andyvand)
Soundfonts that are not respecting the 46 zero-sample padding-space
previously sounded incorrect when
synth.dynamic-sample-loading was active (FluidSynth/fluidsynth#1484)
Allow drum channels to profit from Soundfont Bank Offsets by no
longer ignoring MSB Bank changes (FluidSynth/fluidsynth#1475)
Revise the preset fallback logic for drum channels
(FluidSynth/fluidsynth#1486)
A regression introduced in 2.4.1 may have caused interrupted
real-time playback when voices were using the lowpass filter
(FluidSynth/fluidsynth#1481)
Improve multi-user experience when running fluidsynth as systemd
service (FluidSynth/fluidsynth#1491, thanks to @andrew-sayers)
Fix ordering and dependencies of fluidsynth's systemd service
(FluidSynth/fluidsynth#1500, thanks to @fabiangreffrath)
Revise fluidsynth's man page (FluidSynth/fluidsynth#1499, thanks to
@fabiangreffrath)
fluidsynth 2.4.3
It was discovered, that exclusive class note terminations were too
slow (FluidSynth/fluidsynth#1467, thanks to @mrbumpy409)
Fix a regression introduced in 2.4.0 that allowed the amplitude of a
voice playing in delay phase to rise infinitely
(FluidSynth/fluidsynth#1451)
MSGS drum-style note-cut has been converted to an opt-in setting
synth.note-cut (FluidSynth/fluidsynth#1466)
Support for SDL2 has been disabled by default*
(FluidSynth/fluidsynth#1472)
Fix a regression introduced in 2.4.1 that could have caused infinite
audio gain output for some MIDI files under certain configurations
(FluidSynth/fluidsynth#1464)
Silence a warning issued by Systemd v254+
(FluidSynth/fluidsynth#1474, thanks to @andrew-sayers)
fluidsynth 2.4.2
Fix audible clicks when turning off voices while using a high filter
resonance (FluidSynth/fluidsynth#1427)
Fix a build failure with MSYS2 and MinGW when processing
VersionResource.rc (FluidSynth/fluidsynth#1448, thanks to @pedrolcl)
Fix a crash on startup when there are no MIDI devices available on
Windows (FluidSynth/fluidsynth#1446, thanks to @pedrolcl)
Restore discovery of libsndfile (FluidSynth/fluidsynth#1445)
Fix a race condition when loading SF3 files containing multiple
uncompressed samples (FluidSynth/fluidsynth#1457)
fluidsynth 2.4.1
Enable libsndfile to use filename with non-ASCII characters on
Windows (FluidSynth/fluidsynth#1416, thanks to @pedrolcl and
@stardusteyes)
Fix a few commandline encoding related issues on Windows
(FluidSynth/fluidsynth#1388, FluidSynth/fluidsynth#openwrt#1421, thanks to
@pedrolcl)
Fix build errors on Windows (FluidSynth/fluidsynth#1419,
FluidSynth/fluidsynth#openwrt#1422, thanks to @carlo-bramini)
Fix clicks and pops caused when changing parameters of the lowpass
filter (FluidSynth/fluidsynth#1415, FluidSynth/fluidsynth#openwrt#1417,
FluidSynth/fluidsynth#openwrt#1424)
Minor adjustment to AWE32 NRPN behavior (FluidSynth/fluidsynth#1430)
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
added a commit
to dangowrt/packages
that referenced
this pull request
Apr 26, 2025
fluidsynth 2.4.5
Prebuilt Windows Binaries were missing SDL3.dll
(FluidSynth/fluidsynth#1510)
Fix SDL3 intercepting signals, causing CTRL+C to not quit fluidsynth
(FluidSynth/fluidsynth#1509)
Fix a few flaws in the AWE32 NRPN implementation
(FluidSynth/fluidsynth#1452, FluidSynth/fluidsynth#1473)
A regression introduced in 2.4.4 broke drum preset selection for XG
MIDIs (FluidSynth/fluidsynth#1508)
Fix for OpenMP thread affinity crashes on Android devices
(FluidSynth/fluidsynth#1521, thanks to @looechao)
Fix fluidsynth's systemd user daemon being unable to create lock
file on some distros (FluidSynth/fluidsynth#1527, thanks to
@andrew-sayers)
Fix fluidsynth ignoring initialFilterFc generator limits
(FluidSynth/fluidsynth#1502)
A regression introduced in 2.3.6 prevented SF2 NRPN messages from
being processed correctly (FluidSynth/fluidsynth#1536)
fluidsynth 2.4.4
Support for SDL3 has been added, support for SDL2 has been
deprecated (FluidSynth/fluidsynth#1485, FluidSynth/fluidsynth#1478,
thanks to @andyvand)
Soundfonts that are not respecting the 46 zero-sample padding-space
previously sounded incorrect when
synth.dynamic-sample-loading was active (FluidSynth/fluidsynth#1484)
Allow drum channels to profit from Soundfont Bank Offsets by no
longer ignoring MSB Bank changes (FluidSynth/fluidsynth#1475)
Revise the preset fallback logic for drum channels
(FluidSynth/fluidsynth#1486)
A regression introduced in 2.4.1 may have caused interrupted
real-time playback when voices were using the lowpass filter
(FluidSynth/fluidsynth#1481)
Improve multi-user experience when running fluidsynth as systemd
service (FluidSynth/fluidsynth#1491, thanks to @andrew-sayers)
Fix ordering and dependencies of fluidsynth's systemd service
(FluidSynth/fluidsynth#1500, thanks to @fabiangreffrath)
Revise fluidsynth's man page (FluidSynth/fluidsynth#1499, thanks to
@fabiangreffrath)
fluidsynth 2.4.3
It was discovered, that exclusive class note terminations were too
slow (FluidSynth/fluidsynth#1467, thanks to @mrbumpy409)
Fix a regression introduced in 2.4.0 that allowed the amplitude of a
voice playing in delay phase to rise infinitely
(FluidSynth/fluidsynth#1451)
MSGS drum-style note-cut has been converted to an opt-in setting
synth.note-cut (FluidSynth/fluidsynth#1466)
Support for SDL2 has been disabled by default*
(FluidSynth/fluidsynth#1472)
Fix a regression introduced in 2.4.1 that could have caused infinite
audio gain output for some MIDI files under certain configurations
(FluidSynth/fluidsynth#1464)
Silence a warning issued by Systemd v254+
(FluidSynth/fluidsynth#1474, thanks to @andrew-sayers)
fluidsynth 2.4.2
Fix audible clicks when turning off voices while using a high filter
resonance (FluidSynth/fluidsynth#1427)
Fix a build failure with MSYS2 and MinGW when processing
VersionResource.rc (FluidSynth/fluidsynth#1448, thanks to @pedrolcl)
Fix a crash on startup when there are no MIDI devices available on
Windows (FluidSynth/fluidsynth#1446, thanks to @pedrolcl)
Restore discovery of libsndfile (FluidSynth/fluidsynth#1445)
Fix a race condition when loading SF3 files containing multiple
uncompressed samples (FluidSynth/fluidsynth#1457)
fluidsynth 2.4.1
Enable libsndfile to use filename with non-ASCII characters on
Windows (FluidSynth/fluidsynth#1416, thanks to @pedrolcl and
@stardusteyes)
Fix a few commandline encoding related issues on Windows
(FluidSynth/fluidsynth#1388, FluidSynth/fluidsynth#1421, thanks to
@pedrolcl)
Fix build errors on Windows (FluidSynth/fluidsynth#1419,
FluidSynth/fluidsynth#1422, thanks to @carlo-bramini)
Fix clicks and pops caused when changing parameters of the lowpass
filter (FluidSynth/fluidsynth#1415, FluidSynth/fluidsynth#1417,
FluidSynth/fluidsynth#1424)
Minor adjustment to AWE32 NRPN behavior (FluidSynth/fluidsynth#1430)
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
added a commit
to openwrt/packages
that referenced
this pull request
Apr 26, 2025
fluidsynth 2.4.5
Prebuilt Windows Binaries were missing SDL3.dll
(FluidSynth/fluidsynth#1510)
Fix SDL3 intercepting signals, causing CTRL+C to not quit fluidsynth
(FluidSynth/fluidsynth#1509)
Fix a few flaws in the AWE32 NRPN implementation
(FluidSynth/fluidsynth#1452, FluidSynth/fluidsynth#1473)
A regression introduced in 2.4.4 broke drum preset selection for XG
MIDIs (FluidSynth/fluidsynth#1508)
Fix for OpenMP thread affinity crashes on Android devices
(FluidSynth/fluidsynth#1521, thanks to @looechao)
Fix fluidsynth's systemd user daemon being unable to create lock
file on some distros (FluidSynth/fluidsynth#1527, thanks to
@andrew-sayers)
Fix fluidsynth ignoring initialFilterFc generator limits
(FluidSynth/fluidsynth#1502)
A regression introduced in 2.3.6 prevented SF2 NRPN messages from
being processed correctly (FluidSynth/fluidsynth#1536)
fluidsynth 2.4.4
Support for SDL3 has been added, support for SDL2 has been
deprecated (FluidSynth/fluidsynth#1485, FluidSynth/fluidsynth#1478,
thanks to @andyvand)
Soundfonts that are not respecting the 46 zero-sample padding-space
previously sounded incorrect when
synth.dynamic-sample-loading was active (FluidSynth/fluidsynth#1484)
Allow drum channels to profit from Soundfont Bank Offsets by no
longer ignoring MSB Bank changes (FluidSynth/fluidsynth#1475)
Revise the preset fallback logic for drum channels
(FluidSynth/fluidsynth#1486)
A regression introduced in 2.4.1 may have caused interrupted
real-time playback when voices were using the lowpass filter
(FluidSynth/fluidsynth#1481)
Improve multi-user experience when running fluidsynth as systemd
service (FluidSynth/fluidsynth#1491, thanks to @andrew-sayers)
Fix ordering and dependencies of fluidsynth's systemd service
(FluidSynth/fluidsynth#1500, thanks to @fabiangreffrath)
Revise fluidsynth's man page (FluidSynth/fluidsynth#1499, thanks to
@fabiangreffrath)
fluidsynth 2.4.3
It was discovered, that exclusive class note terminations were too
slow (FluidSynth/fluidsynth#1467, thanks to @mrbumpy409)
Fix a regression introduced in 2.4.0 that allowed the amplitude of a
voice playing in delay phase to rise infinitely
(FluidSynth/fluidsynth#1451)
MSGS drum-style note-cut has been converted to an opt-in setting
synth.note-cut (FluidSynth/fluidsynth#1466)
Support for SDL2 has been disabled by default*
(FluidSynth/fluidsynth#1472)
Fix a regression introduced in 2.4.1 that could have caused infinite
audio gain output for some MIDI files under certain configurations
(FluidSynth/fluidsynth#1464)
Silence a warning issued by Systemd v254+
(FluidSynth/fluidsynth#1474, thanks to @andrew-sayers)
fluidsynth 2.4.2
Fix audible clicks when turning off voices while using a high filter
resonance (FluidSynth/fluidsynth#1427)
Fix a build failure with MSYS2 and MinGW when processing
VersionResource.rc (FluidSynth/fluidsynth#1448, thanks to @pedrolcl)
Fix a crash on startup when there are no MIDI devices available on
Windows (FluidSynth/fluidsynth#1446, thanks to @pedrolcl)
Restore discovery of libsndfile (FluidSynth/fluidsynth#1445)
Fix a race condition when loading SF3 files containing multiple
uncompressed samples (FluidSynth/fluidsynth#1457)
fluidsynth 2.4.1
Enable libsndfile to use filename with non-ASCII characters on
Windows (FluidSynth/fluidsynth#1416, thanks to @pedrolcl and
@stardusteyes)
Fix a few commandline encoding related issues on Windows
(FluidSynth/fluidsynth#1388, FluidSynth/fluidsynth#1421, thanks to
@pedrolcl)
Fix build errors on Windows (FluidSynth/fluidsynth#1419,
FluidSynth/fluidsynth#1422, thanks to @carlo-bramini)
Fix clicks and pops caused when changing parameters of the lowpass
filter (FluidSynth/fluidsynth#1415, FluidSynth/fluidsynth#1417,
FluidSynth/fluidsynth#1424)
Minor adjustment to AWE32 NRPN behavior (FluidSynth/fluidsynth#1430)
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
BKPepe
pushed a commit
to openwrt/packages
that referenced
this pull request
Sep 13, 2025
fluidsynth 2.4.5
Prebuilt Windows Binaries were missing SDL3.dll
(FluidSynth/fluidsynth#1510)
Fix SDL3 intercepting signals, causing CTRL+C to not quit fluidsynth
(FluidSynth/fluidsynth#1509)
Fix a few flaws in the AWE32 NRPN implementation
(FluidSynth/fluidsynth#1452, FluidSynth/fluidsynth#1473)
A regression introduced in 2.4.4 broke drum preset selection for XG
MIDIs (FluidSynth/fluidsynth#1508)
Fix for OpenMP thread affinity crashes on Android devices
(FluidSynth/fluidsynth#1521, thanks to @looechao)
Fix fluidsynth's systemd user daemon being unable to create lock
file on some distros (FluidSynth/fluidsynth#1527, thanks to
@andrew-sayers)
Fix fluidsynth ignoring initialFilterFc generator limits
(FluidSynth/fluidsynth#1502)
A regression introduced in 2.3.6 prevented SF2 NRPN messages from
being processed correctly (FluidSynth/fluidsynth#1536)
fluidsynth 2.4.4
Support for SDL3 has been added, support for SDL2 has been
deprecated (FluidSynth/fluidsynth#1485, FluidSynth/fluidsynth#1478,
thanks to @andyvand)
Soundfonts that are not respecting the 46 zero-sample padding-space
previously sounded incorrect when
synth.dynamic-sample-loading was active (FluidSynth/fluidsynth#1484)
Allow drum channels to profit from Soundfont Bank Offsets by no
longer ignoring MSB Bank changes (FluidSynth/fluidsynth#1475)
Revise the preset fallback logic for drum channels
(FluidSynth/fluidsynth#1486)
A regression introduced in 2.4.1 may have caused interrupted
real-time playback when voices were using the lowpass filter
(FluidSynth/fluidsynth#1481)
Improve multi-user experience when running fluidsynth as systemd
service (FluidSynth/fluidsynth#1491, thanks to @andrew-sayers)
Fix ordering and dependencies of fluidsynth's systemd service
(FluidSynth/fluidsynth#1500, thanks to @fabiangreffrath)
Revise fluidsynth's man page (FluidSynth/fluidsynth#1499, thanks to
@fabiangreffrath)
fluidsynth 2.4.3
It was discovered, that exclusive class note terminations were too
slow (FluidSynth/fluidsynth#1467, thanks to @mrbumpy409)
Fix a regression introduced in 2.4.0 that allowed the amplitude of a
voice playing in delay phase to rise infinitely
(FluidSynth/fluidsynth#1451)
MSGS drum-style note-cut has been converted to an opt-in setting
synth.note-cut (FluidSynth/fluidsynth#1466)
Support for SDL2 has been disabled by default*
(FluidSynth/fluidsynth#1472)
Fix a regression introduced in 2.4.1 that could have caused infinite
audio gain output for some MIDI files under certain configurations
(FluidSynth/fluidsynth#1464)
Silence a warning issued by Systemd v254+
(FluidSynth/fluidsynth#1474, thanks to @andrew-sayers)
fluidsynth 2.4.2
Fix audible clicks when turning off voices while using a high filter
resonance (FluidSynth/fluidsynth#1427)
Fix a build failure with MSYS2 and MinGW when processing
VersionResource.rc (FluidSynth/fluidsynth#1448, thanks to @pedrolcl)
Fix a crash on startup when there are no MIDI devices available on
Windows (FluidSynth/fluidsynth#1446, thanks to @pedrolcl)
Restore discovery of libsndfile (FluidSynth/fluidsynth#1445)
Fix a race condition when loading SF3 files containing multiple
uncompressed samples (FluidSynth/fluidsynth#1457)
fluidsynth 2.4.1
Enable libsndfile to use filename with non-ASCII characters on
Windows (FluidSynth/fluidsynth#1416, thanks to @pedrolcl and
@stardusteyes)
Fix a few commandline encoding related issues on Windows
(FluidSynth/fluidsynth#1388, FluidSynth/fluidsynth#1421, thanks to
@pedrolcl)
Fix build errors on Windows (FluidSynth/fluidsynth#1419,
FluidSynth/fluidsynth#1422, thanks to @carlo-bramini)
Fix clicks and pops caused when changing parameters of the lowpass
filter (FluidSynth/fluidsynth#1415, FluidSynth/fluidsynth#1417,
FluidSynth/fluidsynth#1424)
Minor adjustment to AWE32 NRPN behavior (FluidSynth/fluidsynth#1430)
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
(cherry picked from commit dd8780e)
liudf0716
pushed a commit
to liudf0716/packages
that referenced
this pull request
Oct 23, 2025
fluidsynth 2.4.5
Prebuilt Windows Binaries were missing SDL3.dll
(FluidSynth/fluidsynth#1510)
Fix SDL3 intercepting signals, causing CTRL+C to not quit fluidsynth
(FluidSynth/fluidsynth#1509)
Fix a few flaws in the AWE32 NRPN implementation
(FluidSynth/fluidsynth#1452, FluidSynth/fluidsynth#1473)
A regression introduced in 2.4.4 broke drum preset selection for XG
MIDIs (FluidSynth/fluidsynth#1508)
Fix for OpenMP thread affinity crashes on Android devices
(FluidSynth/fluidsynth#1521, thanks to @looechao)
Fix fluidsynth's systemd user daemon being unable to create lock
file on some distros (FluidSynth/fluidsynth#1527, thanks to
@andrew-sayers)
Fix fluidsynth ignoring initialFilterFc generator limits
(FluidSynth/fluidsynth#1502)
A regression introduced in 2.3.6 prevented SF2 NRPN messages from
being processed correctly (FluidSynth/fluidsynth#1536)
fluidsynth 2.4.4
Support for SDL3 has been added, support for SDL2 has been
deprecated (FluidSynth/fluidsynth#1485, FluidSynth/fluidsynth#1478,
thanks to @andyvand)
Soundfonts that are not respecting the 46 zero-sample padding-space
previously sounded incorrect when
synth.dynamic-sample-loading was active (FluidSynth/fluidsynth#1484)
Allow drum channels to profit from Soundfont Bank Offsets by no
longer ignoring MSB Bank changes (FluidSynth/fluidsynth#1475)
Revise the preset fallback logic for drum channels
(FluidSynth/fluidsynth#1486)
A regression introduced in 2.4.1 may have caused interrupted
real-time playback when voices were using the lowpass filter
(FluidSynth/fluidsynth#1481)
Improve multi-user experience when running fluidsynth as systemd
service (FluidSynth/fluidsynth#1491, thanks to @andrew-sayers)
Fix ordering and dependencies of fluidsynth's systemd service
(FluidSynth/fluidsynth#1500, thanks to @fabiangreffrath)
Revise fluidsynth's man page (FluidSynth/fluidsynth#1499, thanks to
@fabiangreffrath)
fluidsynth 2.4.3
It was discovered, that exclusive class note terminations were too
slow (FluidSynth/fluidsynth#1467, thanks to @mrbumpy409)
Fix a regression introduced in 2.4.0 that allowed the amplitude of a
voice playing in delay phase to rise infinitely
(FluidSynth/fluidsynth#1451)
MSGS drum-style note-cut has been converted to an opt-in setting
synth.note-cut (FluidSynth/fluidsynth#1466)
Support for SDL2 has been disabled by default*
(FluidSynth/fluidsynth#1472)
Fix a regression introduced in 2.4.1 that could have caused infinite
audio gain output for some MIDI files under certain configurations
(FluidSynth/fluidsynth#1464)
Silence a warning issued by Systemd v254+
(FluidSynth/fluidsynth#1474, thanks to @andrew-sayers)
fluidsynth 2.4.2
Fix audible clicks when turning off voices while using a high filter
resonance (FluidSynth/fluidsynth#1427)
Fix a build failure with MSYS2 and MinGW when processing
VersionResource.rc (FluidSynth/fluidsynth#1448, thanks to @pedrolcl)
Fix a crash on startup when there are no MIDI devices available on
Windows (FluidSynth/fluidsynth#1446, thanks to @pedrolcl)
Restore discovery of libsndfile (FluidSynth/fluidsynth#1445)
Fix a race condition when loading SF3 files containing multiple
uncompressed samples (FluidSynth/fluidsynth#1457)
fluidsynth 2.4.1
Enable libsndfile to use filename with non-ASCII characters on
Windows (FluidSynth/fluidsynth#1416, thanks to @pedrolcl and
@stardusteyes)
Fix a few commandline encoding related issues on Windows
(FluidSynth/fluidsynth#1388, FluidSynth/fluidsynth#1421, thanks to
@pedrolcl)
Fix build errors on Windows (FluidSynth/fluidsynth#1419,
FluidSynth/fluidsynth#1422, thanks to @carlo-bramini)
Fix clicks and pops caused when changing parameters of the lowpass
filter (FluidSynth/fluidsynth#1415, FluidSynth/fluidsynth#1417,
FluidSynth/fluidsynth#1424)
Minor adjustment to AWE32 NRPN behavior (FluidSynth/fluidsynth#1430)
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
(cherry picked from commit dd8780e)
(cherry picked from commit 8587135)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fluidsynth includes a systemd user service, which listens on TCP port 9800 by default. So if a computer starts a second user session, that session's service immediately fails because port 9800 is already in use. Lightdm implements its login prompt as a user session, so this can happen just by misclicking the "switch user" button. I assume other display managers are the same, but haven't checked.
This PR is a set of loosely-connected suggestions that would have helped as I went down this particular rabbit hole. I figure they're easier to review together, but happy to edit/split out/remove anything that doesn't fit.