Skip to content

Replace VERSIONINFO resource cmake macro#1449

Merged
derselbst merged 1 commit intoFluidSynth:masterfrom
pedrolcl:fix_1448
Dec 10, 2024
Merged

Replace VERSIONINFO resource cmake macro#1449
derselbst merged 1 commit intoFluidSynth:masterfrom
pedrolcl:fix_1448

Conversation

@pedrolcl
Copy link
Copy Markdown
Contributor

@pedrolcl pedrolcl commented Dec 8, 2024

Fix #1448

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 8, 2024

@derselbst derselbst added this to the 2.4 milestone Dec 10, 2024
Copy link
Copy Markdown
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@derselbst derselbst merged commit 3eaf722 into FluidSynth:master Dec 10, 2024
@pedrolcl pedrolcl deleted the fix_1448 branch December 10, 2024 21:50
DominusExult added a commit to DominusExult/fluidsynth-sans-glib that referenced this pull request Dec 27, 2024
* master: (66 commits)
  Add portamento test files
  Restore discovery of libsndfile on Ubuntu (FluidSynth#1454)
  Fix crash on startup when there are no MIDI devices  (FluidSynth#1447)
  Replace VERSIONINFO resource cmake macro (FluidSynth#1449)
  Fix filter processing order in DSP chain (FluidSynth#1444)
  Render the nervous filter with additional soundfonts
  Add Christian's SF2 spec test to regression tests
  Bump testdata ref
  Migrate test files from LFS to submodule
  Delete test files from Git LFS
  Bump to 2.4.1
  Smooth linear filter parameter change (FluidSynth#1432)
  Reenable AWE32 NRPN 23 and 24 (FluidSynth#1430)
  indentation issue
  Disable chorus for Uplift - it's too noisy in the middle part
  Add Klerg's renderings of Altitude and Uplift
  updated cmake build system * debug output for libsndfile, quieter output for pulseaudio * enhanced build summary report * revised building win32 binaries without unicode support
  add cmake output for sndfile issues
  Fix CI builds (FluidSynth#1435)
  Add test files for AWE32 NRPN (FluidSynth#1434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure when processing VersionResource.rc

2 participants