stop propagating gcc flags to nvcc#92
Merged
FloopCZ merged 1 commit intoFloopCZ:v1.8.0from May 9, 2018
Merged
Conversation
stop propagating gcc flag to nvcc - static build
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 6, 2018
Summary: When we directly use -std=c++11, it propagates to the downstream applications. Problems: 1. Gcc flags propagating to nvcc. 2. nvcc flags propagating to nvcc. (Which throws an error like redeclaration of std flag) This PR will fix these propagation issues! Similar problem: FloopCZ/tensorflow_cc#92 CGAL/cgal#2775 Requires: Cmake 3.12 Pull Request resolved: #10098 Differential Revision: D9187110 Pulled By: ezyang fbshipit-source-id: 0e00e6aa3119c77a5b3ea56992ef3bbfecd71d80
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 6, 2018
Summary: When we directly use -std=c++11, it propagates to the downstream applications. Problems: 1. Gcc flags propagating to nvcc. 2. nvcc flags propagating to nvcc. (Which throws an error like redeclaration of std flag) This PR will fix these propagation issues! Similar problem: FloopCZ/tensorflow_cc#92 CGAL/cgal#2775 Requires: Cmake 3.12 Pull Request resolved: pytorch/pytorch#10098 Differential Revision: D9187110 Pulled By: ezyang fbshipit-source-id: 0e00e6aa3119c77a5b3ea56992ef3bbfecd71d80
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: When we directly use -std=c++11, it propagates to the downstream applications. Problems: 1. Gcc flags propagating to nvcc. 2. nvcc flags propagating to nvcc. (Which throws an error like redeclaration of std flag) This PR will fix these propagation issues! Similar problem: FloopCZ/tensorflow_cc#92 CGAL/cgal#2775 Requires: Cmake 3.12 Pull Request resolved: pytorch#10098 Differential Revision: D9187110 Pulled By: ezyang fbshipit-source-id: 0e00e6aa3119c77a5b3ea56992ef3bbfecd71d80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to stop propagating gcc flags to nvcc. I am using c++14 for both cuda and c++. Tensorflow passed std=c++11 thorough target_compile_options which broke my code. This pull request fixes this issue.
This change requires cmake > 3.3
Similar issue: CGAL/cgal#2775