Skip to content

feat: make automatic configuration reloading the default behavior#4899

Merged
gazpachoking merged 2 commits intoFlexget:developfrom
vivodi:autoreload
Mar 5, 2026
Merged

feat: make automatic configuration reloading the default behavior#4899
gazpachoking merged 2 commits intoFlexget:developfrom
vivodi:autoreload

Conversation

@vivodi
Copy link
Copy Markdown
Contributor

@vivodi vivodi commented Mar 2, 2026

Motivation for changes:

Paranoidi pointed out in #4860 that we should make --autoreload-config the default behavior and add --no-autoreload-config to disable it.

Detailed changes:

Make --autoreload-config the default behavior and add --no-autoreload-config to disable it.

Addressed issues/feature requests:

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.48%. Comparing base (76ff36f) to head (37298ae).
⚠️ Report is 5 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
flexget/manager.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4899      +/-   ##
===========================================
- Coverage    66.48%   66.48%   -0.01%     
===========================================
  Files          583      583              
  Lines        53825    53828       +3     
  Branches      6920     6921       +1     
===========================================
+ Hits         35784    35785       +1     
- Misses       16519    16521       +2     
  Partials      1522     1522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gazpachoking
Copy link
Copy Markdown
Member

gazpachoking commented Mar 4, 2026

Should we leave the --autoreload-config so that we don't break people's scripts? (It wouldn't really do anything anymore, but at least you wouldn't get an error if your e.g. cron entry had it.)

@gazpachoking gazpachoking added this pull request to the merge queue Mar 5, 2026
@gazpachoking
Copy link
Copy Markdown
Member

Looks good, thanks!

Merged via the queue into Flexget:develop with commit 10bf192 Mar 5, 2026
22 checks passed
@vivodi vivodi deleted the autoreload branch March 5, 2026 02:42
nbarrientos added a commit to nbarrientos/docker-flexget that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants