Make pyload plugin work without packaging installed#2642
Merged
gazpachoking merged 1 commit intoFlexget:developfrom Mar 27, 2020
Merged
Make pyload plugin work without packaging installed#2642gazpachoking merged 1 commit intoFlexget:developfrom
gazpachoking merged 1 commit intoFlexget:developfrom
Conversation
Signed-off-by: Stefan Bischoff <stefan.bischoff@9plus.de>
Member
|
Looks good, thanks for this! |
kepi
added a commit
to kepi/Flexget
that referenced
this pull request
Dec 26, 2020
Pyload is currently not working with packaging installed (on both stable and ng) and it is probably not working on pyload-ng with or without packaging installed. What is wrong ============= For stable ----------- GET method for /getServerVersion will not work as we have to be logged in. This returned completely wrong data which were later acted on. For pyload-ng ------------- This was working only when packaging was installed. In Flexget#2642 there was attempt to work without packaging, but IMHO it simply turns the version checking off and pyload is always considered non ng. How to fix it ============= I chose rather simple approach. We currently don't really need exact pyload version. We only need to know if we are on stable or ng. And we can easily detect it by testing login response, no need to do whole magic around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Bischoff stefan.bischoff@9plus.de
Fixes #2641
packaging is now optional. if not found, the pyload plugin assumes, the old api should be used