Skip to content

Added Tray icon#2621

Merged
liiight merged 35 commits intodevelopfrom
tray_icon
Mar 18, 2020
Merged

Added Tray icon#2621
liiight merged 35 commits intodevelopfrom
tray_icon

Conversation

@liiight
Copy link
Copy Markdown
Member

@liiight liiight commented Mar 12, 2020

Motivation for changes:

A nice tray icon to be added on daemon mode run.

Detailed changes:

  • Added TrayIcon and moved manager.start() to its own thread

@liiight liiight changed the title Added Tray icon plugin [WIP] Added Tray icon plugin Mar 12, 2020
@paranoidi
Copy link
Copy Markdown
Member

Tray icon should be enabled by default, no need to make it unnecessay complicated to use.

@gazpachoking
Copy link
Copy Markdown
Member

Not sure if we can do this in a plugin given the requirements for running in main thread and blocking. Might have to be just built in if we add it.

@liiight liiight changed the title [WIP] Added Tray icon plugin [WIP] Added Tray icon Mar 12, 2020
@liiight
Copy link
Copy Markdown
Member Author

liiight commented Mar 12, 2020

Changed it to threads. It's ugly though since there's a dependency between TrayIcon and Manager. tray needs manager for its shutdown and reload config methods, and manager needs to call tray_icon.stop() when it shutsdown...

@gazpachoking @paranoidi any ideas on how to make this nicer?

@liiight
Copy link
Copy Markdown
Member Author

liiight commented Mar 14, 2020

Seems tests are failing since by running pip-compile on a mac, it compiled so mac specific deps. I guess in this case we need to add the higher level package (pystray) directly to the requirement.txt file and let it resolve on the client machine.
This will be a problem with future pip-compiles though...

@liiight liiight changed the title [WIP] Added Tray icon Added Tray icon Mar 14, 2020
@liiight liiight merged commit 786bd83 into develop Mar 18, 2020
wastrachan added a commit to wastrachan/docker-flexget that referenced this pull request Mar 25, 2020
PR #2621 (Flexget/Flexget#2621) added a dependency on Pillow.
Pillow has several libraries it requires that needed to be added to the Dockerfile
@FlexGet-Bot
Copy link
Copy Markdown
Contributor

This pull request has been mentioned on Forum - FlexGet. There might be relevant details there:

https://discuss.flexget.com/t/dependencies-on-non-pure-python-modules/5086/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants