Skip to content

add support for popular/trending list on trakt#2346

Merged
gazpachoking merged 3 commits intoFlexget:developfrom
HeikoBornholdt:trakt_trending_popular
Mar 4, 2019
Merged

add support for popular/trending list on trakt#2346
gazpachoking merged 3 commits intoFlexget:developfrom
HeikoBornholdt:trakt_trending_popular

Conversation

@HeikoBornholdt
Copy link
Copy Markdown

Motivation for changes:

I need that feature for myself.

Detailed changes:

Add support for trending/popular list for trakt_list plugin.

Implemented feature requests:

  • Feathub #40.

Config usage:

trakt_list:
  username: <trakt username>
  list: popular # new values: trending, popular
  type: shows  # allowed values for trending/popular list: movies, shows

@gazpachoking
Copy link
Copy Markdown
Member

Looks good to me. Technically we don't need username/account in the config for these, but I think it might complicated the schema more than it's worth to fix that.

@gazpachoking
Copy link
Copy Markdown
Member

On second thought, it might not be too bad. I think updating the current 'anyOf' in the config would release the requirement for username for these lists:

        'anyOf': [
            {'anyOf': [{'required': ['username']}, {'required': ['account']}]},
            # The 'trending' and 'popular' lists don't require an username
            {'properties': {'list': {'enum': ['trending', 'popular']}}}
        ],

I haven't tested though, not sure if there are any other implications.

@gazpachoking
Copy link
Copy Markdown
Member

Oh, one more thing. IMMUTABLE_LISTS should be updated to have 'trending' and 'popular' in there, so that a good error message is produced if an user tries to edit them.

@HeikoBornholdt
Copy link
Copy Markdown
Author

Thanks for the feedback. I've updated the PR.

@gazpachoking gazpachoking merged commit 2bb14a2 into Flexget:develop Mar 4, 2019
@gazpachoking
Copy link
Copy Markdown
Member

Excellent, thanks! Can you update the wiki with the new options as well?

@snickers2k
Copy link
Copy Markdown

awesome! only thing i'm "missing" is a limiter. How is this solved? How many movies are "trending/popular" ?

@snickers2k
Copy link
Copy Markdown

snickers2k commented Apr 26, 2019

okay.. again, why no limiiter ? Is this really working for you @HeikoBornholdt ? Now i have 155k (155 069) items in my list watchlist .. so this broke my watchlist... and because the main-watchlist can't be deleted, this broke my whole trakt account ...

@HeikoBornholdt
Copy link
Copy Markdown
Author

Sorry to hear that. I agree that we need to limit the number of entries.

I am not sure that we should implement a limiter only for trakt or as global feature for any kind of lists.
@gazpachoking What do you think about that?

@gazpachoking
Copy link
Copy Markdown
Member

Yeah, guess a limiter is needed if those lists are so big. Not sure the best way to go. We could make a plugin similar to limit_new which acts earlier and just cuts off the entries at a certain number (limit_new isn't) appropriate for this case since it doesn't act until after filtering, and adds supplemental entries to the backlog.) This wouldn't be optimal for plugins that have to scan through multiple pages for results, as they'd do extra work if they were getting results past those limits. In that case the only good option I see would be to add limit to the plugin itself.

Easiest way to go is probably just add a limit option to trakt_list. Maybe the default should be dynamic, and set to unlimited for regular lists, but limit popular and trending to something sane by default.

@gazpachoking
Copy link
Copy Markdown
Member

Limit option has been added now in #2366

@snickers2k
Copy link
Copy Markdown

snickers2k commented May 21, 2019

thank you guys for taking the time!

btw. trakt support was really quick to answer my email back and deleted the watchlist for me. next time i use a custom-watchlist for testing i guess :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants