Eliminate rpc timeout. Remove --timeout option#2327
Merged
gazpachoking merged 1 commit intodevelopfrom Feb 6, 2019
Merged
Conversation
Member
Author
|
Original change was here, #2268, which was in response to rpyc instating a default 30 second timeout. This PR reverts flexget behavior to that before the rpyc change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
The timeout on rpc connections put a hard limit on how long a cli client would stay connected to the daemon. It would abort streaming the results back after this timeout was reached (regardless of activity.)
The user should not need to specify --timeout parameter for long running client sessions. The --timeout name was also very non-intuitive as to what it did, how was one to know this was the length of time you would stay connected to daemon?
Detailed changes:
Addressed issues: