Skip to content

fix rpyc calls timing out after 30 seconds#2268

Merged
cvium merged 2 commits intoFlexget:developfrom
chestm007:fixrpyctimeouts
Dec 11, 2018
Merged

fix rpyc calls timing out after 30 seconds#2268
cvium merged 2 commits intoFlexget:developfrom
chestm007:fixrpyctimeouts

Conversation

@chestm007
Copy link
Copy Markdown
Contributor

@chestm007 chestm007 commented Dec 8, 2018 •
edited
Loading

Motivation for changes:

rpyc started actually timing out sync requests in 4.0.0 tomerfiliba-org/rpyc#264

Detailed changes:

  • add --timeout argument to Manager
  • add sync_request_timeout to signature of IPCClient.__init__()
  • pass timeout through to IPCClient in Manager.start()

Addressed issues:

Log and/or tests output (preferably both):

paste output here

@chestm007
fix rpyc calls timing out after 30 seconds
04e298e 
added --timeout to manager arguments (default 1 hour)
pass this setting through to rpyc.utils.factory.connect_channel()
This was referenced Dec 8, 2018
Merged
Merged
@cvium
Copy link
Copy Markdown
Contributor

cvium commented Dec 11, 2018

Why 1 hour?

@chestm007
Copy link
Copy Markdown
Contributor Author

chestm007 commented Dec 11, 2018

Why 1 hour?

Absolutely no reason and a completely arbitrary time that I'm in no way attched too - more then happy to change to whatever people feel is appropriate

@cvium
Copy link
Copy Markdown
Contributor

cvium commented Dec 11, 2018

I think maybe something like 5 minutes? I'm not too sure what the consequence of this timeout is though.

@chestm007
Copy link
Copy Markdown
Contributor Author

chestm007 commented Dec 11, 2018

I think maybe something like 5 minutes? I'm not too sure what the consequence of this timeout is though.

As far as I've seen locally, it just interupt's execution if, for example you run flexget execute and it takes longer then the timeout - its not deal breaking.

I'll update it to 5 minutes, It doesn't seem unreasonable - and there's a cli flag there anyway if the default isn't long enough for some insanely complex config.

@cvium cvium merged commit 20dfec1 into Flexget:develop Dec 11, 2018
@cvium
Copy link
Copy Markdown
Contributor

cvium commented Dec 11, 2018

Cool. Thanks.

@ksurl
Copy link
Copy Markdown
Contributor

ksurl commented Jan 24, 2019 •
edited
Loading

where would the timeout flag be called? like this? flexget execute --timeout 3600 --tasks task? I have the manager result expired error for sftp transfers of large files. how would you specify this in a config in the task?

edit: found the syntax from flexget --help for interactive runs. how about config for daemon scheduler?

@cvium cvium mentioned this pull request Feb 5, 2019
Closed
@gazpachoking gazpachoking mentioned this pull request Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chestm007 @cvium @ksurl