Upgrade rpyc and pip-tools.#2195
Closed
tobinjt wants to merge 14 commits intoFlexget:developfrom
tobinjt:rpyc_dependency
Closed
Upgrade rpyc and pip-tools.#2195tobinjt wants to merge 14 commits intoFlexget:developfrom tobinjt:rpyc_dependency
tobinjt wants to merge 14 commits intoFlexget:developfrom
tobinjt:rpyc_dependency
Conversation
To make debugging easier, log contents of fetched URLs at trace level. Browsers process Javascript, handle iframes, and more that flexget doesn't; seeing the actual data processed by flexget rather than looking at the URL in your browser makes it easier to figure out why you're not getting any results.
#1558 will systemically handle this problem.
- pip-tools < 2.0.1 is incompatible with pip >= 10: jazzband/pip-tools#648 - rpyc < 4.0 is broken with Python 3.7 because 'async' is now a keyword: tomerfiliba-org/rpyc#253
|
I already got #2193 going, we should probably merge these two. |
Member
I agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Fix Python 3.7 breakage.
Make updating dependencies work.
Detailed changes:
Upgrade rpyc and pip-tools.
Addressed issues:
Implemented feature requests:
Config usage if relevant (new plugin or updated schema):
None.
Log and/or tests output (preferably both):
Cannot test properly until #2162 is merged because that's also a fix for Python 3.7.
To Do:
None.