Fetch more of the series data exposed by NPO.nl#1529
Fetch more of the series data exposed by NPO.nl#1529liiight merged 2 commits intoFlexget:developfrom mfonville:develop
Conversation
|
just add the values to the entries you return: |
|
Ok thanks, for that hint. I incorporated that change in my updated commit, and now return several How can I now make sure that e.g. the value of Also, should I add any tests for these changes? And is the coding-style ok, or should I do some things in a different way? |
|
add a |
|
ok thanks, I now added the I also started a test-class, but having some trouble, because there was not one yet for Would you be able to help me out a bit? |
|
if you could set up a real account for flexget and use that it would be ideal |
|
@liiight I set-up the account: I added Als de dijken breken to its favourites (so that are the series indexed by Update: I added the credentials also to the test file |
flexget/tests/test_npo_watchlist.py
Outdated
There was a problem hiding this comment.
that's not gonna work. You need ==.
There was a problem hiding this comment.
ah, yes, thanks for spotting that!
(I do a lot of shell programming, so tend to mix it up sometimes ;-) )
|
Added some tests to it, thank you @liiight for your help with that! It should be ok to merge at this point |
|
np, thank you for contributing. update wiki if relevant |
Motivation for changes:
NPO.nl exposes more information about the series than currently offered by the 'searching for broadcasts' URL that we use (e.g. http://www.npo.nl/als-de-dijken-breken/VPWON_1261083/search?category=broadcasts )
If you visit and fetch the official series URL (e.g. http://www.npo.nl/als-de-dijken-breken/VPWON_1261083 ) this extra information is exposed via a small snippet:
Detailed changes:
I do need some further guidance how to integrate this further, and make sure the fields are exposed in a proper manner.