add ssl support to webserver by b2un0 · Pull Request #1408 · Flexget/Flexget

b2un0 · 2016-09-16T12:33:45Z

Motivation for changes:

remote access to flexget

Detailed changes:

add ssl support to webserver.py (cherrypy)

Config usage if relevant (new plugin or updated schema):

web_server:
  bind: 0.0.0.0
  port: 3539
  ssl_certificate: '/etc/ssl/private/myCert.pem'
  ssl_private_key: '/etc/ssl/private/myKey.key'
api: yes
webui: yes

b2un0 · 2016-09-16T12:38:39Z

stevezau · 2016-09-16T12:57:43Z

Ah! this has been on the todo list for a while..

I think we should support the generation of a self signed certificate?

paranoidi · 2016-09-16T12:56:27Z

flexget/webserver.py

                'bind': {'type': 'string', 'format': 'ipv4', 'default': '0.0.0.0'},
                'port': {'type': 'integer', 'default': 3539},
+                'ssl_certificate': {'type': 'string', 'format': 'string', 'default': ''},
+                'ssl_private_key': {'type': 'string', 'format': 'string', 'default': ''},


I believe in schema you can tell that both of these are required or neither.

they are not required, if you don't set them, the webserver starts without ssl.

b2un0 · 2016-09-16T13:17:39Z

I think we should support the generation of a self signed certificate?
self signed certificate even works

Tommatheussen · 2016-09-16T13:24:19Z

What I believe @stevezau meant is provide a way to the user that allows Flexget to create self-signed certificates

liiight · 2016-09-16T13:47:20Z

@stevezau if that is what you meant, allow flexget to create the ssl, I don't think we need that.

I believe @paranoidi meant json schema dependencies: https://spacetelescope.github.io/understanding-json-schema/reference/object.html#dependencies

Specifically bidirectional dependencies.

cvium · 2016-09-16T19:15:00Z

flexget/webserver.py


-        log.info('Web interface available at http://%s:%s' % (host, self.port))
+        if self.ssl_certificate and self.ssl_private_key:
+            log.info('Web interface available at https://%s:%s' % (host, self.port))


Let the logger handle string formatting ie. log.info('Web interface available at https://%s:%s' , host, self.port)

liiight · 2016-09-18T07:16:42Z

Please set the schema to reflect a bidirectional dependency:

'depenedencies': {
  'ssl_certificate': ['ssl_private_key'],
  'ssl_private_key': ['ssl_certificate']
}

b2un0 · 2016-09-19T08:52:50Z

dependencies was added

cvium · 2016-09-19T08:53:58Z

flexget/webserver.py


        if self.ssl_certificate and self.ssl_private_key:
-            log.info('Web interface available at https://%s:%s' % (host, self.port))
+            proto = 'https'


Might as well call it protocol.

cvium · 2016-09-19T08:54:50Z

flexget/webserver.py

-            log.info('Web interface available at http://%s:%s' % (host, self.port))
+            proto = 'http'
+
+        log.info('Web interface available at %s://%s:%s' % (proto, host, self.port))


Let the logger handle the string formatting here as well

liiight · 2016-09-19T13:49:37Z

You forgot to change the logger formatting, that's the only thing left

b2un0 · 2016-09-20T08:08:44Z

i does not understand what you mean?!

liiight · 2016-09-20T08:13:59Z

Change:
log.info('Web interface available at %s://%s:%s' % (protocol, host, self.port))
Into:
log.info('Web interface available at %s://%s:%s' ,protocol, host, self.port)
The logger module knows when it needs to interpolate the strings itself and it's considered a good practice.

b2un0 · 2016-09-20T08:15:58Z

ah, okay.

i just used the original line and add the protocol parameter;
https://github.com/Flexget/Flexget/blob/develop/flexget/webserver.py#L221

liiight · 2016-09-20T08:16:32Z

yeah, it wasn't right before 😉
might as well do it right the second time.

b2un0 · 2016-09-20T08:17:38Z

finally done :)

liiight · 2016-09-20T08:44:19Z

thanks for this

add ssl support to webserver

d8d4f03

paranoidi reviewed Sep 16, 2016

View reviewed changes

cvium reviewed Sep 16, 2016

View reviewed changes

add ssl support to webserver #1408

ee087fc

cvium reviewed Sep 19, 2016

View reviewed changes

add ssl support to webserver #1408

44f3a2d

add ssl support to webserver #1408

e117d45

liiight merged commit 1c9c3f5 into Flexget:develop Sep 20, 2016

Tommatheussen mentioned this pull request Sep 20, 2016

WebUI: add HTTPS to web_server #1006

Closed

Conversation

b2un0 commented Sep 16, 2016

Motivation for changes:

Detailed changes:

Config usage if relevant (new plugin or updated schema):

Uh oh!

b2un0 commented Sep 16, 2016

Uh oh!

stevezau commented Sep 16, 2016

Uh oh!

paranoidi Sep 16, 2016

Choose a reason for hiding this comment

Uh oh!

b2un0 Sep 16, 2016

Choose a reason for hiding this comment

Uh oh!

b2un0 commented Sep 16, 2016

Uh oh!

Tommatheussen commented Sep 16, 2016

Uh oh!

liiight commented Sep 16, 2016

Uh oh!

cvium Sep 16, 2016

Choose a reason for hiding this comment

Uh oh!

b2un0 Sep 19, 2016

Choose a reason for hiding this comment

Uh oh!

liiight commented Sep 18, 2016

Uh oh!

b2un0 commented Sep 19, 2016

Uh oh!

cvium Sep 19, 2016

Choose a reason for hiding this comment

Uh oh!

cvium Sep 19, 2016

Choose a reason for hiding this comment

Uh oh!

liiight commented Sep 19, 2016

Uh oh!

b2un0 commented Sep 20, 2016

Uh oh!

liiight commented Sep 20, 2016

Uh oh!

b2un0 commented Sep 20, 2016

Uh oh!

liiight commented Sep 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

b2un0 commented Sep 20, 2016

Uh oh!

liiight commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

liiight commented Sep 20, 2016 •

edited

Loading