npo_watchlist: Rewrite, after big changes to npo.nl#1334
npo_watchlist: Rewrite, after big changes to npo.nl#1334cvium merged 4 commits intoFlexget:developfrom
Conversation
Now creates entries for: - individual episodes put on watchlist - all episodes for series on watchlist (since max_episode_age_days)
(forgot to finish a sentence)
| profile_response = self._get_profile(task, config) | ||
| profile_page = BeautifulSoup(profile_response.content, 'html5lib') | ||
| response = self._get_page(task, config, 'https://mijn.npo.nl/profiel/kijklijst') | ||
| page = BeautifulSoup(response.content, 'html5lib') |
There was a problem hiding this comment.
You should use https://github.com/Flexget/Flexget/blob/develop/flexget/utils/soup.py#L15 instead
| If 'remove_accepted' is set to 'yes', the plugin will delete accepted entries from the watchlist after download | ||
| is complete. | ||
| is complete. | ||
| If 'max_episode_age_days' is set (and not 0), entries will only be generated for episodes broadcast in the last x days. |
There was a problem hiding this comment.
Codacy complains about a trailing whitespace after the dot. Please remove it.
|
You mind updating the wiki? |
|
@jeroenl sorry for contacting you in this PR, but I would like to contact you about the npo_watchlist plugin in combination with tvdb. I am currently having trouble to make the episodes found via npo_watchlist to be matched with tvdb (using I believe technically it should be possible to use the seriesname + airdate to find the correct episode. |
|
Hey @mfonville, I tried that earlier but stopped because most programs are not listed in those databases. Happy to try and help though... can you tell me what series/program you are trying to do this with? |
|
@jeroenl I am trying some popular programs that are maintained (partly by me) in tvdb, like "Zondag met Lubach", "Tegenlicht" (can sometimes only be found if querying for "Backlight"), "Keuringsdienst van Waarde", "Koefnoen" and "Toren C" |
|
@mfonville With #1452 I got it working with Koefnoen. For Zondag met Lubach, the issue is that thetvdb_lookup searches by the English title, which is apparently Sunday with Lubach. You can try to modify thetvdb_lookup to allow specifying the language. Alternatively, you can have the title changed to the English title, using a combination of regexp and set. |
|
@jeroenl thanks very much for implementing that! I gave I am not acquainted with the FlexGet codebase at all (trying to make this set-up was my first endeavour). |
|
@mfonville I'm not familiar enough with the tvdb plugin to be able to say how to do that. Perhaps the developer of that plug-in can help? Or try it out, see if you can make it work (that's how I got started with this one). The simple solution is with regexp+set, or actually if+set should also work. See http://flexget.com/Plugins/if This seems to work (at least for ZmL): |
|
@mfonville By the way, out of curiosity: do you maintain the episode data on TVDB manually? Update it every time there's a new episode? |
|
@jeroenl thanks for these examples! Yes, I do update them manually, but luckily I am not alone and often other users contribute for these series too. Often I also just process them a bit batch-like, i.e. Tegenlicht secretly shares the name of their upcoming episodes via their MeetUp schedule X-D Were you thinking about automatically crawling NPO to submit the info to TVDB? |
|
No just curious, I think I'm fine without tvdb. I suppose it's partially Op di 18 okt. 2016 23:34 schreef Maarten Fonville <notifications@github.com
|
|
The big benefit for me (and why I add them) is that TVDB information is supplied to trakt.tv, and I use trakt to keep track of which episodes I have seen :-) Some series of NPO have some kind of series and episode data, when they were released on DVD, and that this pattern has been continued with new broadcasts added to TVDB. |
|
@gazpachoking @liiight |
|
np, but please open another issue for that |
|
@jeroenl I contacted NPO.nl recently and asked them if they could include the Do you think that would be possible? :) |
|
@mfonville I hadn't heard of any XML scheme. Can you give an example? Perhaps in a separate issue, to stop spamming the others on this discussion. |
Motivation for changes:
npo.nl completely changed the set-up of its watchlist, requiring a rewrite of the plug-in.
Detailed changes:
Now creates entries for:
Config usage if relevant (new plugin or updated schema):