Request to pull Rotten Tomatoes plugin changes#1
Merged
paranoidi merged 6 commits intoFlexget:masterfrom Feb 17, 2012
Merged
Conversation
Member
Author
|
I found a bug where it will always perform an RT lookup, even if it has the imdb_id. I'll fix up a workaround but I may not get to it until this weekend. |
Member
There was a problem hiding this comment.
module level constants should be in upper case, although looks like we don't have that everywhere anyway ... :)
Member
|
Looks very good, only thing that would make this superb is (minimal) unit tests. |
… 'require_certified_fresh' to reject entries
Member
Author
|
So are you just waiting on RST comments and some unit tests to accept? |
paranoidi
added a commit
that referenced
this pull request
Feb 17, 2012
Request to pull Rotten Tomatoes plugin.
gazpachoking
pushed a commit
that referenced
this pull request
Jun 13, 2015
Rework wait for magenetization based on input from Gazpachoking.
stevezau
added a commit
that referenced
this pull request
Nov 11, 2017
3 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've written a Rotten Tomatoes plugin based on the existing TMDB and IMDB plugins. It works pretty well. Let me know if there's anything I need to do.
Thanks!