[fix] web server inserts base_url into webui v2#2518
Merged
kristenmills merged 1 commit intodevelopfrom Dec 7, 2019
Merged
Conversation
1 task
gazpachoking
approved these changes
Dec 7, 2019
Member
gazpachoking
left a comment
There was a problem hiding this comment.
Looks fine to me, I haven't done anything with webui in a long time though, so I'm really just trusting you. 😉
liiight
approved these changes
Dec 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Webui v2 was broken if you specify a base url. This is part of the fix, Flexget/webui#43 is the rest
Detailed changes:
{{ base_url }}.Addressed issues:
This can (and should) be merged before the webui pr as it's basically a noop on older builds of webui. The other way around is not the case.