Skip to content

[fix] Support the base_url config on the webserver#43

Merged
kristenmills merged 2 commits intodevelopfrom
fix-base-url
Dec 7, 2019
Merged

[fix] Support the base_url config on the webserver#43
kristenmills merged 2 commits intodevelopfrom
fix-base-url

Conversation

@kristenmills
Copy link
Copy Markdown
Member

@kristenmills kristenmills commented Dec 5, 2019

Motivation for changes:

Fixes the base url issues.

Detailed changes:

  • generate a jinja template instead of raw html to fill in the base url
  • fix the router and the fetch client to use document.baseURI
  • fix the public path for css files

Addressed issues:

Implemented feature requests:

  • Feathub #XX.

To Do:

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 7, 2019

Codecov Report

Merging #43 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
+ Coverage    52.72%   52.78%   +0.06%     
===========================================
  Files          120      120              
  Lines         1542     1544       +2     
  Branches       185      185              
===========================================
+ Hits           813      815       +2     
  Misses         718      718              
  Partials        11       11
Impacted Files Coverage Δ
src/core/api/index.ts 70% <100%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd76b00...1ace639. Read the comment docs.

@kristenmills kristenmills merged commit b4368d4 into develop Dec 7, 2019
@kristenmills kristenmills deleted the fix-base-url branch December 12, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web UI v2 does not respect web_server.base_url configuration option

1 participant