*updated PR* npo_watchlist: Rewrite to support new npo.nl layout#1907
*updated PR* npo_watchlist: Rewrite to support new npo.nl layout#1907liiight merged 7 commits intoFlexget:developfrom mfonville:npo_summer17
Conversation
|
does this replace #1901 then? |
|
yes, this supersedes #1901 |
|
you guys should have used the same branch then :) |
|
I can't commit to his personal branch ;-) |
|
A few other requests that aren't wrapped in try except. Fix those and I think we're good |
|
I now updated the branch with the try-except statements for the requests, can this please be merged so that the plugin works again? Thanks! |
|
As I wrote in Gitter, I am stuck why the Travis build keeps failing (for me I get even the same error on flexget/develop branch), I had hoped that the exception stuff should now have been fixed. If one of the devs could take a look, that'd be a great help because I will be afk for awhile. |
|
@mfonville as i wrote to you on gitter, build crashes were unrelated to your code. merge from dev and it should be fine |
Known issue: removing watchlist entries sometimes results in a 500 error, would appreciate any suggestions.
updated PR of #1901 with some minor fixes/changes and updated tests
Closes #1892 and closes #1893 and closes #1901.