npo_watchlist: Rewrite to support new npo.nl layout#1901
Closed
jeroenl wants to merge 3 commits intoFlexget:developfrom
Closed
npo_watchlist: Rewrite to support new npo.nl layout#1901jeroenl wants to merge 3 commits intoFlexget:developfrom
jeroenl wants to merge 3 commits intoFlexget:developfrom
Conversation
Known issue: removing watchlist entries sometimes results in a 500 error, would appreciate any suggestions.
Contributor
Author
|
I don't know how to update the cassette. @mfonville, can you help? |
Member
|
Delete them and rerun tests |
Contributor
Author
|
Ok, as npo.nl seems to have deleted all accounts (my personal account was also gone), I can't run these tests. @mfonville, do you know what the set up of this account was? |
Contributor
|
npo.nl has introduced indeed a new account system, so we have to re-create an account with a throw-away email address. In the old test-account (and what would be most easy to do again for the new account) was that I had added "Zondag met Lubach" and "Als de dijken breken" as favorite series |
Contributor
|
I have re-created now a new test-account, I will try to see if I can fix the tests for you |
Member
|
Closed due to #1907 |
Contributor
Author
|
Thanks, @mfonville! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known issue: removing watchlist entries sometimes results in a 500 error, would appreciate any suggestions.
Closes #1892 and closes #1893.