test: don't use foo-bar.net in TestHTTPClientMakeHTTPDialer#174
Merged
wetcod merged 2 commits intoFinschia:developfrom Feb 4, 2021
Merged
test: don't use foo-bar.net in TestHTTPClientMakeHTTPDialer#174wetcod merged 2 commits intoFinschia:developfrom
wetcod merged 2 commits intoFinschia:developfrom
Conversation
This test relied on connecting to the external site `foo-bar.net`, and (predictably) the site went down and broke all of our CI runs. This changes it to use local HTTP servers instead. (cherry picked from commit f54f80bf0d464ffec6facf98e447ee403bbf1e8c)
5 tasks
Codecov Report
@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
- Coverage 62.52% 62.43% -0.09%
===========================================
Files 283 283
Lines 26475 26480 +5
===========================================
- Hits 16554 16534 -20
- Misses 8576 8598 +22
- Partials 1345 1348 +3
|
tnasu
approved these changes
Feb 3, 2021
kokehiM0chi
approved these changes
Feb 3, 2021
Contributor
kokehiM0chi
left a comment
There was a problem hiding this comment.
What does this value Hi!\n mean ?
https://github.com/line/tendermint/pull/174/files#diff-2b6e7e0353cdd8f2400baf409cc0206c48d2ac16dbfd68457cead476444123efR15
Contributor
Author
This is cherry-picked PR, so I don't know exactly what the original author meant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI fails because of test relied on connecting to the external site.
So cherry-pick tendermint/tendermint#5997
And increase the
test_covertimeoutFor contributor use:
docs/) and code commentsFiles changedin the Github PR explorer