Skip to content

Set utf-8 in export_to_json#5829

Merged
cowtowncoder merged 1 commit into
FasterXML:3.xfrom
tejasae-afk:fix/set-utf-8-in-export-to-json
Mar 22, 2026
Merged

Set utf-8 in export_to_json#5829
cowtowncoder merged 1 commit into
FasterXML:3.xfrom
tejasae-afk:fix/set-utf-8-in-export-to-json

Conversation

@tejasae-afk

Copy link
Copy Markdown
Contributor

The code around line 165 in filter_popular_issues.py looked like it might have an issue. it relies on the process default encoding. this patch makes the file open explicit about utf-8 so it behaves the same across environments.

Happy to revise the approach or close this if it doesn’t fit — you know the codebase far better than I do.

@cowtowncoder

Copy link
Copy Markdown
Member

@tejasae-afk Sounds good, thank you!

@cowtowncoder cowtowncoder merged commit 441a33c into FasterXML:3.x Mar 22, 2026
4 checks passed
@github-actions

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 81.35% 📈 +0.000%
Branches branches 74.58% 📈 +0.010%

Coverage data generated from JaCoCo test results

pjfanning pushed a commit that referenced this pull request Mar 22, 2026
Co-authored-by: tejasae-afk <tejasae-afk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants