remove gmail.com.au from free email domains#911
Merged
pimjansen merged 1 commit intoFakerPHP:1.24from Nov 15, 2024
Merged
Conversation
7 tasks
Author
|
I've recreated PR(#885) but branched from 1.24 instead of 2.0. Hopefully that solves the failing pipeline |
pimjansen
approved these changes
Nov 15, 2024
1 task
teal-bauer
pushed a commit
to starsong-consulting/faker-php
that referenced
this pull request
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
freeEmail()function for AU provider included the domaingmail.com.au, which does not exist. It causes failing tests when validating emails withemail:rfc,dnsgmail.com.audomain causes email validation to fail #886 )Author's checklist
Summary of changes
Removed the errant domain from the en_AU/Internet provider file
Review checklist
CHANGELOG.md