Thanks! Will review later. Initially it all looks fine

I think the Static analysis / Psalm failure is unrelated to this PR.

I think the Static analysis / Psalm failure is unrelated to this PR.

Well im not even getting them locally indeed.

@localheinz you got an idea what this could be? Also the error makes no direct sense to me at all

Can we recreate the baseline here?

@pimjansen I have updated the baseline.

Seems like there is still a problem with the baseline.

I updated it using the following command:

vendor/bin/psalm --no-progress --update-baseline

(Never used psalm before)

Me neither so thats why i pinged @localheinz haha. Since i want this PR to be done so we can continue in other libs as well

@pimjansen Okay I have found the problem regarding the baseline.

The option --update-baseline will only removed solved problems from the baseline, it will not add new ones. For that you need to run --set-baseline=psalm.baseline.xml.

I have now added a regenrated psalm baseline, which should make this PR mergeable.

LGTM, cant somehow not merge this via mobile will review tomorrow and push for a 1.24 release

Good work!

Thanks!