timezone() respects countrycode#607
Merged
pimjansen merged 2 commits intoFakerPHP:mainfrom Mar 11, 2023
Merged
Conversation
https://github.com/FakerPHP/Faker/pull/480/files added optional countryCode parameter, to Core and Extension classes, but not the Provider class.
|
Im not a fan of this since a method should be clear what it does. However i do like the feature which we can maybe implement in a seperate method instead. @bram-pkg thoughts? |
Member
|
I think this is fine, as long as it's documented in the docblock and in fakerphp.github.io. |
Author
|
@bram-pkg The documentation already shows that |
pimjansen
approved these changes
Mar 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/FakerPHP/Faker/pull/480/files added optional countryCode parameter, to Core and Extension classes, but not the Provider class.
What is the reason for this PR?
Duplicate existing functionality into Provider\DateTime class
Author's checklist
Summary of changes
Duplicate existing functionality into other class.
Review checklist