Support filtering timezones by country code#480
Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom Jun 22, 2022
Merged
Conversation
|
This is a breaking change so we cant accept this on the main stream |
Member
|
@pimjansen this is an |
Member
|
@aprat84 if we manage to accept this, make sure to also change the method signature in the parent interface. |
ebd97fd to
2a6a0dd
Compare
Author
|
@bram-pkg done! Also changed the phpdoc in Sorry for my ignorance, but, are you sure it is a BC? The I reused the method cause I thought it would be cleaner, but this could be easily done in a separate method (ie: |
bram-pkg
requested changes
Jun 17, 2022
2a6a0dd to
3235eae
Compare
bram-pkg
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Filter creating timezones by country code.
Sometimes it is useful to assign a timezone from same country as the item we are going to create.
Author's checklist
Support filtering timezones by country code fakerphp.github.io#67
Summary of changes
Add
$countryCodeparameter toDateTime::timezone()method, to be able to filter the generated timezone by country.Review checklist