Skip to content

Fixed some hungarian bugs and functions#451

Merged
bram-pkg merged 5 commits intoFakerPHP:mainfrom
zsoltjanes:main
Feb 16, 2022
Merged

Fixed some hungarian bugs and functions#451
bram-pkg merged 5 commits intoFakerPHP:mainfrom
zsoltjanes:main

Conversation

@zsoltjanes
Copy link

@zsoltjanes zsoltjanes commented Feb 8, 2022 •
edited
Loading

What is the reason for this PR?

The hungarian section is fixed, some case was not good.

  • A new feature
  • Fixed an issue

Author's checklist

Summary of changes

Review checklist

  • All checks have passed
  • Changes are approved by maintainer

bram-pkg
bram-pkg reviewed Feb 8, 2022
View reviewed changes
pimjansen
pimjansen previously approved these changes Feb 10, 2022
View reviewed changes
Copy link

@pimjansen pimjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bram-pkg can you have a final look?

@pimjansen
Copy link

pimjansen commented Feb 10, 2022

Lgtm

@bram-pkg can you have a final look?

I was a bit too fast. Missed the BC. Can you review and fix where needed?

@bram-pkg bram-pkg added bug Something isn't working do not merge labels Feb 10, 2022
@zsoltjanes
Copy link
Author

zsoltjanes commented Feb 14, 2022

Can you help me what should I check and fix?

@krsriq
Copy link

krsriq commented Feb 14, 2022

@zsoltjanes the BC checker does not like that this removes the $title property and firstNameMaleNe(): https://github.com/FakerPHP/Faker/runs/5137593918?check_suite_focus=true#step:4:114

@zsoltjanes zsoltjanes requested a review from bram-pkg February 14, 2022 21:38
bram-pkg
bram-pkg requested changes Feb 14, 2022
View reviewed changes
@zsoltjanes zsoltjanes requested a review from bram-pkg February 15, 2022 18:47
@bram-pkg bram-pkg merged commit a8e53bd into FakerPHP:main Feb 16, 2022
@mmarton mmarton mentioned this pull request Jul 21, 2022
Closed
@dorqa95
Copy link

dorqa95 commented Aug 26, 2022 •
edited
Loading

This commit couse me an error with this:
Unknown format "lastNameFemaleMarried". With version 1.19 that bug does not exists. I saw that in the main branch the bug has already fixed. Could you please create a new release with that? #503 #502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bram-pkg bram-pkg bram-pkg approved these changes

@pimjansen pimjansen pimjansen left review comments

Assignees

No one assigned

Labels

bug Something isn't working do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zsoltjanes @pimjansen @krsriq @dorqa95 @bram-pkg