Added missing method for Hungarian married female lastnames#503
Merged
pimjansen merged 1 commit intoFakerPHP:mainfrom Jul 22, 2022
pimjansen:feature/hungarian-female-name
Merged
Added missing method for Hungarian married female lastnames#503pimjansen merged 1 commit intoFakerPHP:mainfrom pimjansen:feature/hungarian-female-name
pimjansen merged 1 commit intoFakerPHP:mainfrom
pimjansen:feature/hungarian-female-name
Conversation
mmarton
approved these changes
Jul 21, 2022
Member
|
@pimjansen quick tests maybe? |
Author
Yeah didnt do it yet since there are none for this Locale at all and had some time constraints. Will add them |
Author
|
@bram-pkg added basic test |
bram-pkg
approved these changes
Jul 22, 2022
Member
|
Just the cs-fixer check is failing now |
Author
Yeah booboo as usual 😭 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
Added missing method
Review checklist