Removed UUID from Generator to be able to extend it#441
Merged
bram-pkg merged 1 commit intoFakerPHP:mainfrom Feb 2, 2022
pimjansen:feature/removed-uuid-from-generator
Merged
Removed UUID from Generator to be able to extend it#441bram-pkg merged 1 commit intoFakerPHP:mainfrom pimjansen:feature/removed-uuid-from-generator
bram-pkg merged 1 commit intoFakerPHP:mainfrom
pimjansen:feature/removed-uuid-from-generator
Conversation
Author
|
This also makes #436 obsolete |
4 tasks
Member
|
Can you add an ignore for this to the bc-roave config? |
Author
|
@bram-pkg done! |
bram-pkg
approved these changes
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Reverts the addition of the UUID method to the generator
Author's checklist
Summary of changes
Since the method exists directly on the generator the
addProvidermethod is not able to extend these calls anymore. There we revert it for now and ensure that on v2 these methods used. For v2 we can overwrite it with the container builder however at this moment these are still experimental.Review checklist