Remove unnecesary docblock magic method definition uuid()#436
Closed
krsriq wants to merge 1 commit intoFakerPHP:mainfrom
Closed
Remove unnecesary docblock magic method definition uuid()#436krsriq wants to merge 1 commit intoFakerPHP:mainfrom
krsriq wants to merge 1 commit intoFakerPHP:mainfrom
Conversation
|
See discussion at #435. |
Author
|
If I understand correctly #435 is about in what order providers are loaded/if methods can be overridden - that's independent of whether they are (or are not) listed in the |
Correct but it could mean we cant adjust it since it is called via a __call method. In this case the class method always has priority. If this is the usecase we probably remove the new v2 extension from the Generator for now. Will have a look into it tomorrow |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
The
uuid()was defined as magic@methodin theGeneratordocblock. In 69dbada theuuid()method was added to theGenerator, making the definition of this method in the docblock unnecessary.Author's checklist
Summary of changes
Removed
uuid()from Generator docblock.Review checklist