[rebase-progressive] Fix/Cleanup CMake files, Fix building with CMake on macOS and Linux, etc#8
Open
WinterPhoenix wants to merge 1 commit intoFacepunch:masterfrom
Open
Conversation
c07a7ff to
c083822
Compare
sohpeach
reviewed
Oct 25, 2025
- Structure CMake files correctly for a CEF project, importing CEF's CMake files - Fix building with CMake on macOS and Linux - Explicitly use -A Windows API functions (presence of UNICODE from CEF CMake forces consideration) - Cleanup JSValue to fix macOS builds - Use correct User Agent version on Linux and macOS - Update README with working instructions to build using CMake on all platforms - Update .gitignore to ignore all CMake build/dist directories, IDE files, recursively ignore thirdparty/cef3, etc - Disable example_host (non-functional as-is and requires changes we'll do separately) Co-authored-by: sohpeach <sohpeach@users.noreply.github.com> Co-authored-by: JohnPeel <john@dgby.org> Co-authored-by: AkikoKumagara <akiko@solsticegamestudios.com> Co-authored-by: Davilarek <davilareko@gmail.com> Co-authored-by: snowkat <snow@datagirl.xyz>
c083822 to
96cbce3
Compare
|
F---ng finally! |
|
Agreed, however this is just a Single PR of a multi part PR project, as explicitly requested by Rubat. |
yeah i've read the other pr |
WinterPhoenix
added a commit
to solsticegamestudios/GModPatchTool
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2nd PR in the series from SGS's gmod-html fork.
Changes in this PR
Motivation for changes
These changes address problems attempting to compile gmod-html using CMake, which is the primary method used outside of Facepunch.
We restructure the CMake files as a proper CEF project, which addresses a whole host of issues by itself. Beyond that, these changes are the absolute minimum necessary for getting compilation to work with CMake on all platforms.
It must be noted that since there are no changes here that address issues running CEF post-compilation, it is still broken on Linux, however fixing that will require updating to a newer CEF version regardless.
This PR also includes working instructions for compiling with CMake on all platforms in the README.