Merged
Conversation
- Update material documentation - Use ShadeMode in VanillaModelEncoder
- Rewrite header packing constants in EncodingFormat to match material packing constants - Pass buffer Function to TerrainRenderContext instead of allocators and buffer map - Restore functionality of ChunkRenderInfo#release - Set captured terrain context to null after releasing it - Bump mixin compatibility level to Java 21 - Remove unused AWs
- Fix RiverstoneUnbakedModel not calling setParents on models that it will bake
Technici4n
suggested changes
Jul 21, 2024
Member
Technici4n
left a comment
There was a problem hiding this comment.
I did not run the code, but I had a thorough look at every change. Looks very good.
...erer-api-v1/src/client/java/net/fabricmc/fabric/api/renderer/v1/material/MaterialFinder.java
Outdated
Show resolved
Hide resolved
...erer-api-v1/src/client/java/net/fabricmc/fabric/api/renderer/v1/material/MaterialFinder.java
Show resolved
Hide resolved
Technici4n
approved these changes
Jul 25, 2024
modmuss50
approved these changes
Jul 27, 2024
PepperCode1
added a commit
to PepperCode1/Indium
that referenced
this pull request
Aug 15, 2024
- Copy changes from FabricMC/fabric-api#3937 - Copy Fabric impl VanillaModelEncoder class to avoid issues - Initialize VanillaAoHelper statically as mods may create their own BlockModelRenderers - Fix issues with buildscript
comp500
pushed a commit
to comp500/Indium
that referenced
this pull request
Aug 15, 2024
- Copy changes from FabricMC/fabric-api#3937 - Copy Fabric impl VanillaModelEncoder class to avoid issues - Initialize VanillaAoHelper statically as mods may create their own BlockModelRenderers - Fix issues with buildscript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShadeModeis a material property and enum with two fields,ENHANCEDandVANILLA. This material property is a hint to the renderer about how the quad is intended to be shaded, for example through ambient occlusion and diffuse shading. The renderer is free to ignore this hint. Similar functionality already existed in Indigo when usingAoConfig.HYBRID, but a vanilla shade mode was hardcoded to always only be applied to quads output by the default implementation ofemitBlockQuads. With a dedicated property exposed in the API, Indigo's code becomes cleaner and users have more control over this behavior.