Skip to content

[#65] Renderer API + Indigo#189

Merged
asiekierka merged 4 commits intoFabricMC:masterfrom
asiekierka:indigo
May 18, 2019
Merged

[#65] Renderer API + Indigo#189
asiekierka merged 4 commits intoFabricMC:masterfrom
asiekierka:indigo

Conversation

@asiekierka
Copy link
Copy Markdown
Contributor

@asiekierka asiekierka commented May 18, 2019

what

@asiekierka asiekierka added 0.3.x ready status: accepted This issue is a good idea and a PR should be made labels May 18, 2019
@asiekierka
Copy link
Copy Markdown
Contributor Author

asiekierka commented May 18, 2019 

Idea: Split away the DynamicModelBakeEntity/TerrainBlockView part of the API into its own module
as it could later be reused in a much simpler version of the patch if someone wants to, more akin to my initial proposal with just a view/pos-specific BakedModel
I just need more approvals for the idea, and a name for the module

I would also rename TerrainBlockView to something else, in that case. Should come with the name of the module, maybeh.

@asiekierka asiekierka mentioned this pull request May 18, 2019
Closed
grondag
grondag reviewed May 18, 2019
View reviewed changes
...nderer-api-v1/src/main/java/net/fabricmc/fabric/api/renderer/v1/material/RenderMaterial.java Outdated
*
* All renderer implementations should support standard materials.<p>
*
* <b>SHADER MATERIALS</b><p>
Copy link
Copy Markdown
Contributor

@grondag grondag May 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs for shader and special materials reference features that didn't make the cut and should probably be removed.

@asiekierka asiekierka merged commit 02a46d5 into FabricMC:master May 18, 2019
@Player3324 Player3324 mentioned this pull request Jun 3, 2019
Closed
ThalusA pushed a commit to ThalusA/fabric that referenced this pull request May 31, 2022
@asiekierka
[FabricMC#65] Renderer API + Indigo (FabricMC#189)
0842b35 
Big thanks to Grondag and Player for all the pain and trouble we all went through.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@grondag grondag grondag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: accepted This issue is a good idea and a PR should be made

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asiekierka @grondag