nhrpd: fixes duplicate auth extension#16808
Merged
Jafaral merged 1 commit intoFRRouting:masterfrom Sep 13, 2024
Merged
Conversation
When an NHRP peer was forwarding a message, it was copying all extensions from the originally received packet. The authentication extension must be regenerated hop by hop per RFC2332. This fix checks for the auth extension when copying extensions and omits the original packet auth and instead regenerates a new auth extension. Fix bug FRRouting#16507 Signed-off-by: Denys Haryachyy <garyachy@gmail.com>
Member
|
ci:rerun ci seems to be stuck |
Member
|
@Mergifyio backport stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been createdDetails
|
Member
auth extension was added very recently, so I think it only affect master, maybe 10.1 too. |
This was referenced Sep 13, 2024
Jafaral
added a commit
that referenced
this pull request
Sep 13, 2024
nhrpd: fixes duplicate auth extension (backport #16808)
donaldsharp
added a commit
that referenced
this pull request
Sep 13, 2024
nhrpd: fixes duplicate auth extension (backport #16808)
donaldsharp
added a commit
that referenced
this pull request
Sep 13, 2024
nhrpd: fixes duplicate auth extension (backport #16808)
donaldsharp
added a commit
that referenced
this pull request
Sep 13, 2024
nhrpd: fixes duplicate auth extension (backport #16808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an NHRP peer was forwarding a message, it was copying all extensions from the originally received packet. The authentication extension must be regenerated hop by hop per RFC2332. This fix checks for the auth extension when copying extensions and omits the original packet auth and instead regenerates a new auth extension.
Fixes #16507